Skip to content

Commit 877755b

Browse files
alexcrichtonthestinger
authored andcommitted
Rewrite pass management with LLVM
Beforehand, it was unclear whether rust was performing the "recommended set" of optimizations provided by LLVM for code. This commit changes the way we run passes to closely mirror that of clang, which in theory does it correctly. The notable changes include: * Passes are no longer explicitly added one by one. This would be difficult to keep up with as LLVM changes and we don't guaranteed always know the best order in which to run passes * Passes are now managed by LLVM's PassManagerBuilder object. This is then used to populate the various pass managers run. * We now run both a FunctionPassManager and a module-wide PassManager. This is what clang does, and I presume that we *may* see a speed boost from the module-wide passes just having to do less work. I have no measured this. * The codegen pass manager has been extracted to its own separate pass manager to not get mixed up with the other passes * All pass managers now include passes for target-specific data layout and analysis passes Some new features include: * You can now print all passes being run with `-Z print-llvm-passes` * When specifying passes via `--passes`, the passes are now appended to the default list of passes instead of overwriting them. * The output of `--passes list` is now generated by LLVM instead of maintaining a list of passes ourselves * Loop vectorization is turned on by default as an optimization pass and can be disabled with `-Z no-vectorize-loops`
1 parent 2c0f9bd commit 877755b

File tree

11 files changed

+449
-755
lines changed

11 files changed

+449
-755
lines changed

src/librustc/back/link.rs

Lines changed: 155 additions & 179 deletions
Large diffs are not rendered by default.

src/librustc/back/passes.rs

Lines changed: 0 additions & 349 deletions
This file was deleted.

src/librustc/driver/driver.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -847,8 +847,9 @@ pub fn optgroups() -> ~[getopts::groups::OptGroup] {
847847
optopt("", "opt-level",
848848
"Optimize with possible levels 0-3", "LEVEL"),
849849
optopt("", "passes", "Comma or space separated list of pass names to use. \
850-
Overrides the default passes for optimization levels,\n\
851-
a value of \"list\" will list the available passes.", "NAMES"),
850+
Appends to the default list of passes to run for the \
851+
specified current optimization level. A value of \
852+
\"list\" will list all of the available passes", "NAMES"),
852853
optopt( "", "out-dir",
853854
"Write output to compiler-chosen filename
854855
in <dir>", "DIR"),

0 commit comments

Comments
 (0)