Skip to content

Commit 60b4a97

Browse files
committed
auto merge of #14562 : jakub-/rust/issue-14541, r=alexcrichton
Fixes #14541
2 parents b387120 + 80e84e0 commit 60b4a97

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

src/librustc/middle/typeck/check/_match.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,8 @@ pub fn check_pat_variant(pcx: &pat_ctxt, pat: &ast::Pat, path: &ast::Path,
298298
/// `etc` is true if the pattern said '...' and false otherwise.
299299
pub fn check_struct_pat_fields(pcx: &pat_ctxt,
300300
span: Span,
301-
path: &ast::Path,
302301
fields: &[ast::FieldPat],
303-
class_fields: Vec<ty::field_ty> ,
302+
class_fields: Vec<ty::field_ty>,
304303
class_id: ast::DefId,
305304
substitutions: &ty::substs,
306305
etc: bool) {
@@ -333,13 +332,12 @@ pub fn check_struct_pat_fields(pcx: &pat_ctxt,
333332
found_fields.insert(index);
334333
}
335334
None => {
336-
let name = pprust::path_to_str(path);
337335
// Check the pattern anyway, so that attempts to look
338336
// up its type won't fail
339337
check_pat(pcx, field.pat, ty::mk_err());
340338
tcx.sess.span_err(span,
341339
format!("struct `{}` does not have a field named `{}`",
342-
name,
340+
ty::item_path_str(tcx, class_id),
343341
token::get_ident(field.ident)).as_slice());
344342
}
345343
}
@@ -390,7 +388,7 @@ pub fn check_struct_pat(pcx: &pat_ctxt, pat_id: ast::NodeId, span: Span,
390388
}
391389
}
392390

393-
check_struct_pat_fields(pcx, span, path, fields, class_fields, struct_id,
391+
check_struct_pat_fields(pcx, span, fields, class_fields, struct_id,
394392
substitutions, etc);
395393
}
396394

@@ -413,7 +411,7 @@ pub fn check_struct_like_enum_variant_pat(pcx: &pat_ctxt,
413411
// Get the struct fields from this struct-like enum variant.
414412
let class_fields = ty::lookup_struct_fields(tcx, variant_id);
415413

416-
check_struct_pat_fields(pcx, span, path, fields, class_fields,
414+
check_struct_pat_fields(pcx, span, fields, class_fields,
417415
variant_id, substitutions, etc);
418416
}
419417
Some(&ast::DefStruct(..)) | Some(&ast::DefVariant(..)) => {

src/test/compile-fail/issue-14541.rs

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
struct vec2 { y: f32 }
12+
struct vec3 { y: f32, z: f32 }
13+
14+
fn make(v: vec2) {
15+
let vec3 { y: _, z: _ } = v;
16+
//~^ ERROR mismatched types: expected `vec2` but found `vec3`
17+
//~^^ ERROR struct `vec2` does not have a field named `z`
18+
}
19+
20+
fn main() { }

0 commit comments

Comments
 (0)