Skip to content

Commit 5de8e04

Browse files
committed
Remove broken redundant backtrace hint
When the compiler driver panics it attempts to show a hint about using `RUST_BACKTRACE`. However, the logic is currently reversed to the hint is only shown if `RUST_BACKTRACE` is *already* set: ```shell > RUST_BACKTRACE=1 rustc /dev/null --crate-type proc-macro error: internal compiler error: unexpected panic ... note: run with `RUST_BACKTRACE=1` for a backtrace thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. > RUST_BACKTRACE=0 rustc /dev/null --crate-type proc-macro error: internal compiler error: unexpected panic ... thread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49 note: Run with `RUST_BACKTRACE=1` for a backtrace. ``` As the `panic` itself already has a working `RUST_BACKTRACE` hint just remove the broken duplicate hint entirely.
1 parent 47a8eb7 commit 5de8e04

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/librustc_driver/lib.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,14 +1276,6 @@ pub fn monitor<F: FnOnce() + Send + 'static>(f: F) {
12761276
&note,
12771277
errors::Level::Note);
12781278
}
1279-
if match env::var_os("RUST_BACKTRACE") {
1280-
Some(val) => &val != "0",
1281-
None => false,
1282-
} {
1283-
handler.emit(&MultiSpan::new(),
1284-
"run with `RUST_BACKTRACE=1` for a backtrace",
1285-
errors::Level::Note);
1286-
}
12871279

12881280
eprintln!("{}", str::from_utf8(&data.lock().unwrap()).unwrap());
12891281
}

0 commit comments

Comments
 (0)