Optimize fmt::PadAdapter::wrap

phlopsi · phlopsi · commit 3e82dca65c22 · 2021-07-11T08:06:29.000+02:00
diff --git a/library/core/src/fmt/builders.rs b/library/core/src/fmt/builders.rs
@@ -23,10 +23,7 @@ impl<'buf, 'state> PadAdapter<'buf, 'state> {
         slot: &'slot mut Option<Self>,
         state: &'state mut PadAdapterState,
     ) -> fmt::Formatter<'slot> {
-        fmt.wrap_buf(move |buf| {
-            *slot = Some(PadAdapter { buf, state });
-            slot.as_mut().unwrap()
-        })
+        fmt.wrap_buf(move |buf| slot.insert(PadAdapter { buf, state }))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,10 +23,7 @@ impl<'buf, 'state> PadAdapter<'buf, 'state> {`
`23`	`23`	`slot: &'slot mut Option<Self>,`
`24`	`24`	`state: &'state mut PadAdapterState,`
`25`	`25`	`) -> fmt::Formatter<'slot> {`
`26`		`- fmt.wrap_buf(move \|buf\| {`
`27`		`- *slot = Some(PadAdapter { buf, state });`
`28`		`- slot.as_mut().unwrap()`
`29`		`- })`
	`26`	`+ fmt.wrap_buf(move \|buf\| slot.insert(PadAdapter { buf, state }))`
`30`	`27`	`}`
`31`	`28`	`}`
`32`	`29`