Skip to content

Commit 3830738

Browse files
committed
auto merge of #8963 : jmgrosen/rust/issue-8881, r=alexcrichton
2 parents 3c4e943 + 4a18d46 commit 3830738

File tree

5 files changed

+23
-10
lines changed

5 files changed

+23
-10
lines changed

src/librustpkg/conditions.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -14,33 +14,33 @@ pub use std::path::Path;
1414
pub use package_id::PkgId;
1515

1616
condition! {
17-
bad_path: (super::Path, ~str) -> super::Path;
17+
bad_path: (Path, ~str) -> Path;
1818
}
1919

2020
condition! {
21-
nonexistent_package: (super::PkgId, ~str) -> super::Path;
21+
nonexistent_package: (PkgId, ~str) -> Path;
2222
}
2323

2424
condition! {
25-
copy_failed: (super::Path, super::Path) -> ();
25+
copy_failed: (Path, Path) -> ();
2626
}
2727

2828
condition! {
29-
missing_pkg_files: (super::PkgId) -> ();
29+
missing_pkg_files: (PkgId) -> ();
3030
}
3131

3232
condition! {
33-
bad_pkg_id: (super::Path, ~str) -> super::PkgId;
33+
bad_pkg_id: (Path, ~str) -> PkgId;
3434
}
3535

3636
condition! {
37-
no_rust_path: (~str) -> super::Path;
37+
no_rust_path: (~str) -> Path;
3838
}
3939

4040
condition! {
41-
not_a_workspace: (~str) -> super::Path;
41+
not_a_workspace: (~str) -> Path;
4242
}
4343

4444
condition! {
45-
failed_to_create_temp_dir: (~str) -> super::Path;
45+
failed_to_create_temp_dir: (~str) -> Path;
4646
}

src/libstd/c_str.rs

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ pub enum NullByteResolution {
2929

3030
condition! {
3131
// this should be &[u8] but there's a lifetime issue
32+
// NOTE: this super::NullByteResolution should be NullByteResolution
33+
// Change this next time the snapshot it updated.
3234
null_byte: (~[u8]) -> super::NullByteResolution;
3335
}
3436

src/libstd/rt/io/mod.rs

+4
Original file line numberDiff line numberDiff line change
@@ -385,13 +385,17 @@ impl ToStr for IoErrorKind {
385385
// Raised by `I/O` operations on error.
386386
condition! {
387387
// FIXME (#6009): uncomment `pub` after expansion support lands.
388+
// NOTE: this super::IoError should be IoError
389+
// Change this next time the snapshot it updated.
388390
/*pub*/ io_error: super::IoError -> ();
389391
}
390392

391393
// XXX: Can't put doc comments on macros
392394
// Raised by `read` on error
393395
condition! {
394396
// FIXME (#6009): uncomment `pub` after expansion support lands.
397+
// NOTE: this super::IoError should be IoError
398+
// Change this next time the snapshot it updated.
395399
/*pub*/ read_error: super::IoError -> ();
396400
}
397401

src/libsyntax/ext/expand.rs

+8
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,11 @@ pub fn std_macros() -> @str {
889889
{ pub $c:ident: $input:ty -> $out:ty; } => {
890890

891891
pub mod $c {
892+
#[allow(unused_imports)];
892893
#[allow(non_uppercase_statics)];
894+
895+
use super::*;
896+
893897
static key: ::std::local_data::Key<
894898
@::std::condition::Handler<$input, $out>> =
895899
&::std::local_data::Key;
@@ -907,7 +911,11 @@ pub fn std_macros() -> @str {
907911

908912
// FIXME (#6009): remove mod's `pub` below once variant above lands.
909913
pub mod $c {
914+
#[allow(unused_imports)];
910915
#[allow(non_uppercase_statics)];
916+
917+
use super::*;
918+
911919
static key: ::std::local_data::Key<
912920
@::std::condition::Handler<$input, $out>> =
913921
&::std::local_data::Key;

src/test/auxiliary/xc_conditions_4.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pub enum Color {
1616
}
1717

1818
condition! {
19-
pub oops: (int,float,~str) -> ::Color;
19+
pub oops: (int,float,~str) -> Color;
2020
}
2121

2222
pub trait Thunk<T> {
@@ -26,4 +26,3 @@ pub trait Thunk<T> {
2626
pub fn callback<T,TH:Thunk<T>>(t:TH) -> T {
2727
t.call()
2828
}
29-

0 commit comments

Comments
 (0)