@@ -181,10 +181,26 @@ pub struct Mutex<T: ?Sized> {
181
181
data : UnsafeCell < T > ,
182
182
}
183
183
184
- // these are the only places where `T: Send` matters; all other
185
- // functionality works fine on a single thread.
184
+ /// Mutex is a container that wraps `T`, so it's necessary for `T` to be `Send`
185
+ /// to safely send `Mutex` to another thread. This ensures that the protected
186
+ /// data can be accessed safely from multiple threads without causing data races
187
+ /// or other unsafe behavior.
188
+ ///
189
+ /// [`Mutex<T>`] provides mutable access to `T` to one thread at a time. However, it's essential
190
+ /// for `T` to be `Send` because it's not safe for non-`Send` structures to be accessed in
191
+ /// this manner. For instance, consider [`Rc`], a non-atomic reference counted smart pointer,
192
+ /// which is not `Send`. With `Rc`, we can have multiple copies pointing to the same heap
193
+ /// allocation with a non-atomic reference count. If we were to use `Mutex<Rc<_>>`, it would
194
+ /// only protect one instance of `Rc` from shared access, leaving other copies vulnerable
195
+ /// to potential data races.
196
+ ///
197
+ /// [`Rc`]: crate::rc::Rc
186
198
#[ stable( feature = "rust1" , since = "1.0.0" ) ]
187
199
unsafe impl < T : ?Sized + Send > Send for Mutex < T > { }
200
+
201
+ /// [`Mutex`] can be `Sync` even if its inner type `T` is not `Sync` itself.
202
+ /// This is because [`Mutex`] provides a safe interface for accessing `T` through
203
+ /// locking mechanisms, ensuring that only one thread can access `T` at a time.
188
204
#[ stable( feature = "rust1" , since = "1.0.0" ) ]
189
205
unsafe impl < T : ?Sized + Send > Sync for Mutex < T > { }
190
206
@@ -211,8 +227,18 @@ pub struct MutexGuard<'a, T: ?Sized + 'a> {
211
227
poison : poison:: Guard ,
212
228
}
213
229
230
+ /// A [`MutexGuard`] is not `Send` to maximize platform portablity.
231
+ /// On platforms that use POSIX thread (commonly referred to as pthreads) there is a requirement to
232
+ /// release mutex locks on the same thread they were acquired.
233
+ /// For this reason, [`MutexGuard`] must not implement `Send` to prevent it being dropped from
234
+ /// another thread.
214
235
#[ stable( feature = "rust1" , since = "1.0.0" ) ]
215
236
impl < T : ?Sized > !Send for MutexGuard < ' _ , T > { }
237
+
238
+ /// A [`MutexGuard`] can be `Sync` even though it is not `Send` because ownership is not transfer to
239
+ /// a new thread. Because ownership always stays on the original thread `Sync`
240
+ /// is safe to implement for [`MutexGuard`].
241
+ /// See the `!Send` implementation on [`MutexGuard`] for more details.
216
242
#[ stable( feature = "mutexguard" , since = "1.19.0" ) ]
217
243
unsafe impl < T : ?Sized + Sync > Sync for MutexGuard < ' _ , T > { }
218
244
0 commit comments