-
Notifications
You must be signed in to change notification settings - Fork 340
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @brson |
Thanks @EFindlay. I'll review Tuesday. |
Just dropping this link real quick: https://dxr.mozilla.org/rust/source/ DXR is supposedly pretty stable and quite useful, so we need to give it exposure. |
I've pushed PRS #201 (community), #200 (docs), and #199 (contributing) to my own gh pages so reviewers can see. The first goal is to get the community page merged since it's the most developed. The key pages under review are community.html, user_groups.html, documentation.html, and contributions.html |
IMO this should be somehow linked on the first page too. |
If you're learning Rust, you've no doubt been amazed at how awesome | ||
the language is and will be keen to write more Rust code. Hopefully, | ||
you'll also want to make a meaningful contribution to the community. | ||
If you're not sure how best to do that, then hopefully this page will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: repeated hopefully.
This looks great to me. I may be rearranging the stuff in this page when I add the other community libraries and other mentorship info, but for now it's pretty good. |
hi! i think this is a great start to a contributing guide- however, it only answers 1 question: "what are the types of things i could work on" it doesn't answer questions like
an example i think of is: i want to contribute to docs. mentioning in this that docs are included in the rust repo itself, that they versioned, how that is affected by release cycles, etc would be all be super useful as they are important things to consider when deciding what and how to contribute. perhaps this info should be in separate |
@ashleygwilliams Thanks for these good points. I'll make three new sections in contributing.md for each of these questions and get working on it. |
I've posted a counter-PR against @EFindlay's branch. It doesn't do a lot new, but it does shuffle bits around: organizes the page into six sections that are listed up front with in-page links. I was hoping this would be simplifying, but my rewritten section on 'bugs' is pretty sprawling. I'll give closer attention to all the other individual sections tomorrow. |
Various changes to contributions.html
No problem! |
This is an adaptation of ncamerons page.
Todo:
stable landing pages to link to, like internals threads or GitHub issues.