Skip to content

Use compilation-mode for rustfmt errors #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roife opened this issue Sep 2, 2024 · 2 comments · Fixed by #556
Closed

Use compilation-mode for rustfmt errors #555

roife opened this issue Sep 2, 2024 · 2 comments · Fixed by #556

Comments

@roife
Copy link
Member

roife commented Sep 2, 2024

See #204, #395.

This is crucial for user experience, yet it seems to have been neglected for quite some time.

Why can't we reuse rust-compile.el for rustfmt? Are there differences between the diagnostics format from rustfmt and rustc?

@roife
Copy link
Member Author

roife commented Sep 2, 2024

I’m glad to tackle this issue, but I’m unsure if my approach (reusing rust-compile.el) is correct. I would greatly appreciate it if maintainers could provide some guidance.

@psibi
Copy link
Member

psibi commented Sep 2, 2024

Sure, I think it would be good to have it. If you want to take inspiration, it's already available as part of rustic mode: https://github.com/emacs-rustic/rustic/blob/d765680373234a6c231acf20c76b07422afcfdf9/rustic-rustfmt.el#L222

Also, please add tests too. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants