Skip to content

Canonicalizing the rust-project.json breaks our VFS #14728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue May 3, 2023 · 1 comment · Fixed by #14735
Closed

Canonicalizing the rust-project.json breaks our VFS #14728

Veykril opened this issue May 3, 2023 · 1 comment · Fixed by #14735
Labels
A-rust-project rust-project.json related issues C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented May 3, 2023

#14430 (comment) broke rust-project.json files that emit relative paths for the root module paths. On windows at least due to nt paths being used which mismatches the entries in the VFS.
@Veykril Veykril added C-bug Category: bug A-rust-project rust-project.json related issues labels May 3, 2023
This was referenced May 3, 2023
Closed
Merged
@bors bors closed this as completed in a7944a9 May 13, 2023
@manyinsects
Copy link
Member

Seems to still be happening to people, even as we ourselves implemented generating absolute paths by default. See a user report here: rust-lang/rustlings#1462 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust-project rust-project.json related issues C-bug Category: bug
Projects
None yet
Milestone
No milestone
2 participants
@Veykril @manyinsects