implement lint groups

Author: HKalbasi

Cargo.lock

@@ -16,6 +16,7 @@ cov-mark = "2.0.0-pre.1"
 either = "1.7.0"
 itertools = "0.10.5"
 serde_json = "1.0.86"
+once_cell = "1.17.0"
 
 # local deps
 profile.workspace = true

crates/ide-diagnostics/Cargo.toml

@@ -495,7 +495,7 @@ pub static SomeStatic: u8 = 10;
         check_diagnostics(
             r#"
 #[deny(non_snake_case)]
-fn NonSnakeCaseName(some_var: u8) -> u8{
+fn NonSnakeCaseName(some_var: u8) -> u8 {
  //^^^^^^^^^^^^^^^^ 💡 error: Function `NonSnakeCaseName` should have snake_case name, e.g. `non_snake_case_name`
     // cov_flags generated output from elsewhere in this file
     extern "C" {
@@ -508,18 +508,16 @@ fn NonSnakeCaseName(some_var: u8) -> u8{
     OtherVar
 }
 
-// FIXME: lint groups are not implemented
-
 #[deny(nonstandard_style)]
 mod CheckNonstandardStyle {
     fn HiImABadFnName() {}
-     //^^^^^^^^^^^^^^ 💡 warn: Function `HiImABadFnName` should have snake_case name, e.g. `hi_im_abad_fn_name`
+     //^^^^^^^^^^^^^^ 💡 error: Function `HiImABadFnName` should have snake_case name, e.g. `hi_im_abad_fn_name`
 }
 
-#[deny(bad_style)]
+#[deny(warnings)]
 mod CheckBadStyle {
     struct fooo;
-         //^^^^ 💡 warn: Structure `fooo` should have CamelCase name, e.g. `Fooo`
+         //^^^^ 💡 error: Structure `fooo` should have CamelCase name, e.g. `Fooo`
 }
 
 mod F {

crates/ide-diagnostics/src/handlers/incorrect_case.rs

@@ -67,16 +67,20 @@ mod handlers {
 #[cfg(test)]
 mod tests;
 
+use std::collections::HashMap;
+
 use hir::{diagnostics::AnyDiagnostic, InFile, Semantics};
 use ide_db::{
     assists::{Assist, AssistId, AssistKind, AssistResolveStrategy},
     base_db::{FileId, FileRange, SourceDatabase},
+    generated::lints::{LintGroup, CLIPPY_LINT_GROUPS, DEFAULT_LINT_GROUPS},
     imports::insert_use::InsertUseConfig,
     label::Label,
     source_change::SourceChange,
     syntax_helpers::node_ext::parse_tt_as_comma_sep_paths,
     FxHashMap, FxHashSet, RootDatabase,
 };
+use once_cell::sync::Lazy;
 use stdx::never;
 use syntax::{
     algo::find_node_at_range,
@@ -370,7 +374,7 @@ pub fn diagnostics(
     let mut rustc_stack: FxHashMap<String, Vec<Severity>> = FxHashMap::default();
     let mut clippy_stack: FxHashMap<String, Vec<Severity>> = FxHashMap::default();
 
-    fun_name(
+    handle_lint_attributes(
         &ctx.sema,
         parse.syntax(),
         &mut rustc_stack,
@@ -387,7 +391,30 @@ pub fn diagnostics(
     res
 }
 
-fn fun_name(
+static RUSTC_LINT_GROUPS_DICT: Lazy<HashMap<&str, Vec<&str>>> =
+    Lazy::new(|| build_group_dict(DEFAULT_LINT_GROUPS, &["warnings"]));
+
+static CLIPPY_LINT_GROUPS_DICT: Lazy<HashMap<&str, Vec<&str>>> =
+    Lazy::new(|| build_group_dict(CLIPPY_LINT_GROUPS, &[]));
+
+fn build_group_dict(
+    lint_group: &'static [LintGroup],
+    all_groups: &'static [&'static str],
+) -> HashMap<&'static str, Vec<&'static str>> {
+    let mut r: HashMap<&str, Vec<&str>> = HashMap::new();
+    for g in lint_group {
+        for child in g.children {
+            r.entry(child).or_default().push(g.lint.label);
+        }
+    }
+    for (lint, groups) in r.iter_mut() {
+        groups.push(lint);
+        groups.extend_from_slice(all_groups);
+    }
+    r
+}
+
+fn handle_lint_attributes(
     sema: &Semantics<'_, RootDatabase>,
     root: &SyntaxNode,
     rustc_stack: &mut FxHashMap<String, Vec<Severity>>,
@@ -406,18 +433,33 @@ fn fun_name(
                 if let Some(x) =
                     diagnostics_of_range.get_mut(&InFile { file_id, value: node.clone() })
                 {
-                    let (name, stack) = match x.code {
-                        DiagnosticOrigin::RustcLint(name) => (name, &mut *rustc_stack),
-                        DiagnosticOrigin::Clippy(name) => (name, &mut *clippy_stack),
+                    const EMPTY_LINTS: &[&str] = &[];
+                    let (names, stack) = match x.code {
+                        DiagnosticOrigin::RustcLint(name) => (
+                            RUSTC_LINT_GROUPS_DICT.get(name).map_or(EMPTY_LINTS, |x| &**x),
+                            &mut *rustc_stack,
+                        ),
+                        DiagnosticOrigin::Clippy(name) => (
+                            CLIPPY_LINT_GROUPS_DICT.get(name).map_or(EMPTY_LINTS, |x| &**x),
+                            &mut *clippy_stack,
+                        ),
                         _ => continue,
                     };
-                    if let Some(s) = stack.get(name).and_then(|x| x.last()) {
-                        x.severity = *s;
+                    for &name in names {
+                        if let Some(s) = stack.get(name).and_then(|x| x.last()) {
+                            x.severity = *s;
+                        }
                     }
                 }
                 if let Some(mc) = ast::MacroCall::cast(node) {
                     if let Some(me) = sema.expand(&mc) {
-                        fun_name(sema, &me, rustc_stack, clippy_stack, diagnostics_of_range);
+                        handle_lint_attributes(
+                            sema,
+                            &me,
+                            rustc_stack,
+                            clippy_stack,
+                            diagnostics_of_range,
+                        );
                     }
                 }
             }