jsonrpc conformance

[chergert]

I was starting to put together a jsonrpc and language server plugin for GNOME Builder and discovered that ls_service.rs seems to require the "id" field be an integer. According to what I've read so far on JSONRPC (which is very little) I believe it should also allow string message identifiers.

[craftytrickster]

According to the spec, looks like you are right:

id
An identifier established by the Client that MUST contain a String, Number, or NULL value if included. If it is not included it is assumed to be a notification. The value SHOULD normally not be Null [1] and Numbers SHOULD NOT contain fractional parts [2]

Since the server has to send the exact same id back to the client, the server should be able to send a string back for a string id, and a number back for a number id.

[chergert]

Agreed, I don't think mixing is an important feature. I think they should just be treated as opaque tokens.

[liamdawson]

Did #79 close this?

[nrc]

I'm pretty sure this is fixed now.