Skip to content

feature: Add chapther numbers to search result breadcrumbs #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WofWca opened this issue Aug 2, 2019 · 0 comments
Open

feature: Add chapther numbers to search result breadcrumbs #992

WofWca opened this issue Aug 2, 2019 · 0 comments

Comments

@WofWca
Copy link
Contributor

WofWca commented Aug 2, 2019

This would make the search results easier to scan is some cases (e.g. when the book is big (like The Book).

Before:
Screen Shot 2019-08-02 at 14 05 54

After:
Screen Shot 2019-08-02 at 14 05 46

It could be implemented as an optional thing.

Here's where they're being generated:
https://github.com/rust-lang-nursery/mdBook/blob/77af889a2e5331c11345ddef935caccb0305cd34/src/renderer/html_handlebars/search.rs#L92

May be better to first make some architecture changes that would make it easier to implement
A quote from #631:

The idea is a nested chapter can have links back to its parent (and maybe siblings?), making things like section numbers and breadcrumbs a lot easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant