Skip to content

!Send Future fails Miri check #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coder137 opened this issue Aug 6, 2024 · 1 comment
Closed

!Send Future fails Miri check #2877

coder137 opened this issue Aug 6, 2024 · 1 comment

Comments

@coder137
Copy link

coder137 commented Aug 6, 2024

Similar to the tokio issue: tokio-rs/tokio#6750
Swapped tokio::join! usage with futures::join! and was able to replicate the same issue

Description

Working on a TickedAsyncExecutor using smol's async_task where the futures only progress when the executor is ticked

The future test only fails when !Send future is used along with futures::join!

Replication

Passing case when Send future
CI: https://github.com/coder137/ticked-async-executor/actions/runs/10259611867/job/28384360359
Branch: https://github.com/coder137/ticked-async-executor/tree/tokio_test
Test: https://github.com/coder137/ticked-async-executor/blob/tokio_test/tests/futures_tests.rs

Failing case when !Send future
CI: https://github.com/coder137/ticked-async-executor/actions/runs/10259553647/job/28384210470
Branch: https://github.com/coder137/ticked-async-executor/tree/tokio_test_spawn_local
Test: https://github.com/coder137/ticked-async-executor/blob/tokio_test_spawn_local/tests/futures_tests.rs

Log info

= help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
= help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information

ubuntu_futures_log.txt

@coder137 coder137 changed the title !Send Future fails Miri Check !Send Future fails Miri check Aug 6, 2024
@taiki-e
Copy link
Member

taiki-e commented Aug 13, 2024

This is not a problem of futures-rs. Closing in favor of an issue in Miri repo.

@taiki-e taiki-e closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants