Skip to content

Make release updating happen in add_package_to_database #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kixiron opened this issue Jun 1, 2020 · 2 comments
Closed

Make release updating happen in add_package_to_database #798

Kixiron opened this issue Jun 1, 2020 · 2 comments
Labels
E-medium Effort: This requires a fair amount of work

Comments

@Kixiron
Copy link
Member

Kixiron commented Jun 1, 2020

Currently we have three separate parts of adding and fully recognizing a new release, add_package_to_database, update_search_index and update_release_activity. These should all be able to be combined, which would remove two side services (both updaters run on separate threads) and make publishing releases more responsive for users

@Kixiron Kixiron added the E-medium Effort: This requires a fair amount of work label Jun 1, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jun 1, 2020

update_search_index writes crates.content which appears to be unused since #721 so it can probably just be dropped and this function deleted.

update_release_activity I assume is for the chart on https://docs.rs/releases/activity, those queries look simple enough, and that page is requested rarely enough, that I don't think those calculations need caching, they could just be done when that page is loaded. (Especially if rewritten to be a single query as I think it can be).

@Kixiron
Copy link
Member Author

Kixiron commented Jun 6, 2020

Closed by #804

@Kixiron Kixiron closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-medium Effort: This requires a fair amount of work
Projects
None yet
Development

No branches or pull requests

2 participants