Skip to content

Increase memory limit for kube-custom-resources-rs #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebhoss opened this issue Nov 5, 2023 · 4 comments
Closed

Increase memory limit for kube-custom-resources-rs #2300

sebhoss opened this issue Nov 5, 2023 · 4 comments

Comments

@sebhoss
Copy link

sebhoss commented Nov 5, 2023

Crate name

kube-custom-resources-rs

Build failure link

https://docs.rs/crate/kube-custom-resources-rs/2023.11.5/builds/960062

Requested RAM limit

32 GB

Requested timeout

No response

Requested number of targets

No response

Why your crate needs the resource increases

The crate is quite big and uses lots of kube-rs macros on all of its structs. Generating the docs locally takes around 30 GB on my machine with --jobs 1.

If increasing the memory limit is not possible, is there some way for me to provide/upload the docs manually?

@syphar
Copy link
Member

syphar commented Nov 5, 2023

while we can and do increase the memory limit on request, due to the current build-server setup our current max is around 12 GB per build. We are working on this but progress is slow.
Building yourself and uploading comes with its own issues around security, see #93.

From what I remember we set a CPU limit of 6 cores for the docker container, so --jobs 6 should be more near to the actual build.

So in the short team I'm happy to increase your limit to 12 GB, if you can make that work.

@sebhoss
Copy link
Author

sebhoss commented Nov 5, 2023

hey thanks for the quick response! I could not generate docs with less memory so far, however I completely get that the requested amount of memory is super high. So I'm thinking about adding a small docs comment to the root of my crate that points to the documentation that I generate/host elsewhere. This would not require any additional hardware on your end and still provide people with some info on docs.rs without #93 to be solved. WDYT?

@syphar
Copy link
Member

syphar commented Nov 5, 2023

however I completely get that the requested amount of memory is super high

btw, depending on how many features a user of the library would use the memory usage this high would also be an issue for many developer or CI systems.

@sebhoss
Copy link
Author

sebhoss commented Nov 5, 2023

yeah I'm painfully aware 🥲 however I'm expecting that only a small number of features will be used in downstream projects. I just need to enable all features to verify that all of them work and the entire documentation is generated. My current work around for documentation is to generate it myself with some custom tooling. It certainly isn't perfect but works well on very old hardware..

So thanks again for the fast response & helpful comments!

@sebhoss sebhoss closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants