Skip to content

Commit d9f1a13

Browse files
committed
start tracking build-start time for build-time reporting
1 parent e7d5518 commit d9f1a13

18 files changed

+60
-44
lines changed

.sqlx/query-771731efe02694173d758c04a4ec616e0171b05f09b71795af14270961fa8bd0.json renamed to .sqlx/query-20e23c3804282f206fcb8f2466a7d0d34e312cd5caeefcd77f0f1a94bd53fcb3.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-65f40f6603b1f3e736566c3d4e275bb47f6ebc389b0aa61f7732d1f354dc5259.json renamed to .sqlx/query-31b24e2e5aea1c5dcd742343aa18e4b1806f0926d3494747854a036421399546.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-649f22aaffbd35cb00a820a68677797e8bbde159b10d04e3945520a61b63ecb0.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

.sqlx/query-7544bfef94310c33c8d34c30bc24e91b4aa2f198c1efd0f9ef562c0b85f4dddb.json

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-8965c22711d10959507118e8e58f4d76a1b03d3a8ca37c18b7a5b9296b94d4ea.json renamed to .sqlx/query-8552f463bfc719f100e0e678b1400ea593a24d5d0c9ef291f786a27669cd626d.json

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-ed7323a8d06dbb475ec470892c1fff8b2ec47de33f2d74e0f1475fdf165e1ac2.json renamed to .sqlx/query-8d4e885b2e5a58241516f98b5739bbdca1225e112fb869858060666750b80f1f.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-224f12feb10c65e8345eb4346c123ba324fde11d9f5bd07ae264761dc38e1f2a.json renamed to .sqlx/query-a2c5c46a3e0058c3bd23d62f1844e3ca5d6b118da33795449e9386525eea912f.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-5a92975ad3d17197b01235b08ea9ff9d5169f8bf7c50315ef96d838b37c18cf1.json renamed to .sqlx/query-d2fd21fb369b3105fe240d865fea786571008fe6088d142fd5f09a15b1a98344.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-c5315b9cdb9ffd0a939705f2700a73a3795cfe8e943716923ed9dfbaed3961af.json renamed to .sqlx/query-f9151734057f3e6562b1a56d1665ad3707b0ca37bbfca2d75e6e05b350dade04.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.sqlx/query-d471c22a41a040f720ac678b085265f616eef21a09ffaaa243fc26f107ad6c87.json renamed to .sqlx/query-f93135119437ea6896864d413e0c6321ba93e043002509290acf736e7210caf2.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
ALTER TABLE builds DROP COLUMN build_started;
2+
ALTER TABLE builds RENAME COLUMN build_finished TO build_time;
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
ALTER TABLE builds
2+
ADD COLUMN build_started TIMESTAMP WITH TIME ZONE;
3+
4+
ALTER TABLE builds
5+
RENAME COLUMN build_time TO build_finished;

src/db/add_package.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ pub async fn update_build_status(conn: &mut sqlx::PgConnection, release_id: i32)
165165
FROM (
166166
SELECT
167167
r.id,
168-
MAX(b.build_time) as last_build_time,
168+
MAX(b.build_finished) as last_build_time,
169169
SUM(CASE WHEN b.build_status = 'success' THEN 1 ELSE 0 END) as success_count,
170170
SUM(CASE WHEN b.build_status = 'failure' THEN 1 ELSE 0 END) as failure_count
171171
FROM
@@ -257,7 +257,7 @@ pub(crate) async fn finish_build(
257257
build_server = $4,
258258
errors = $5,
259259
documentation_size = $6,
260-
build_time = NOW()
260+
build_finished = NOW()
261261
WHERE
262262
id = $7
263263
RETURNING rid",
@@ -348,8 +348,8 @@ pub(crate) async fn initialize_build(
348348
let hostname = hostname::get()?;
349349

350350
let build_id = sqlx::query_scalar!(
351-
"INSERT INTO builds(rid, build_status, build_server)
352-
VALUES ($1, $2, $3)
351+
"INSERT INTO builds(rid, build_status, build_server, build_started)
352+
VALUES ($1, $2, $3, NOW())
353353
RETURNING id",
354354
release_id,
355355
BuildStatus::InProgress as BuildStatus,
@@ -628,6 +628,7 @@ mod test {
628628
r#"SELECT
629629
rustc_version,
630630
docsrs_version,
631+
build_started,
631632
build_status as "build_status: BuildStatus",
632633
errors
633634
FROM builds
@@ -639,6 +640,7 @@ mod test {
639640

640641
assert!(row.rustc_version.is_none());
641642
assert!(row.docsrs_version.is_none());
643+
assert!(row.build_started.is_some());
642644
assert_eq!(row.build_status, BuildStatus::Failure);
643645
assert_eq!(row.errors, Some("error message".into()));
644646

src/web/build_details.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ pub(crate) async fn build_details_handler(
7272
builds.rustc_version,
7373
builds.docsrs_version,
7474
builds.build_status as "build_status: BuildStatus",
75-
builds.build_time,
75+
COALESCE(builds.build_finished, builds.build_started) as build_time,
7676
builds.output,
7777
builds.errors,
7878
releases.default_target

0 commit comments

Comments
 (0)