fix new clippy warnings

Author: syphar

src/test/mod.rs

@@ -18,6 +18,7 @@ use reqwest::{
 };
 use std::thread::{self, JoinHandle};
 use std::{
+    fmt::Write as _,
     fs,
     net::{SocketAddr, TcpListener},
     panic,
@@ -508,7 +509,7 @@ impl TestDatabase {
         crate::db::migrate(None, &mut conn)?;
 
         // Move all sequence start positions 10000 apart to avoid overlapping primary keys
-        let query: String = conn
+        let query = conn
             .query(
                 "
                     SELECT relname
@@ -523,11 +524,15 @@ impl TestDatabase {
             .into_iter()
             .map(|row| row.get(0))
             .enumerate()
-            .map(|(i, sequence): (_, String)| {
+            .fold(String::new(), |mut query, (i, sequence): (_, String)| {
                 let offset = (i + 1) * 10000;
-                format!(r#"ALTER SEQUENCE "{sequence}" RESTART WITH {offset};"#)
-            })
-            .collect();
+                write!(
+                    query,
+                    r#"ALTER SEQUENCE "{sequence}" RESTART WITH {offset};"#
+                )
+                .expect("could not write to string");
+                query
+            });
         conn.batch_execute(&query)?;
 
         Ok(TestDatabase { pool, schema })

src/web/mod.rs

@@ -550,15 +550,15 @@ impl MetaData {
     }
 
     fn parse_doc_targets(targets: Value) -> Vec<String> {
-        let mut targets = targets
+        let mut targets: Vec<_> = targets
             .as_array()
             .map(|array| {
                 array
                     .iter()
                     .filter_map(|item| item.as_str().map(|s| s.to_owned()))
                     .collect()
             })
-            .unwrap_or_else(Vec::new);
+            .unwrap_or_default();
         targets.sort_unstable();
         targets
     }