Auto merge of #2168 - Turbo87:versions, r=locks

mirage/crate: Calculate `max_verison` and `newest_version` properties

This PR simplifies our test fixtures a little bit more by dynamically calculating the `max_verison` and `newest_version` properties of the `crate` resources in mirage. This also reduces a few inconsistencies in our test data.

r? @locks

Author: bors

mirage/factories/crate.js

@@ -16,8 +16,6 @@ export default Factory.extend({
   documentation: null,
   homepage: null,
   repository: null,
-  max_version: '1.0.0',
-  newest_version: '1.0.0',
 
   created_at: '2010-06-16T21:30:45Z',
   updated_at: '2017-02-24T12:34:56Z',

mirage/fixtures/crates.js

@@ -16,8 +16,6 @@ export default [
     homepage: 'https://icorderi.github.io/icorderi/kinetic-rust',
     id: 'kinetic-rust',
     keywordIds: [],
-    max_version: '0.0.16',
-    newest_version: '0.0.16',
     name: 'kinetic-rust',
     repository: 'https://github.com/icorderi/kinetic-rust/',
     updated_at: '2015-04-21T00:15:49Z',
@@ -41,8 +39,6 @@ export default [
     homepage: 'https://github.com/thehydroimpulse/nanomsg.rs',
     id: 'nanomsg',
     keywordIds: ['network'],
-    max_version: '0.7.0-alpha',
-    newest_version: '0.6.1',
     name: 'nanomsg',
     repository: 'https://github.com/thehydroimpulse/nanomsg.rs',
     updated_at: '2016-12-28T08:40:00Z',
@@ -71,8 +67,6 @@ export default [
     homepage: 'https://github.com/huonw/external_mixin',
     id: 'rust_mixin',
     keywordIds: ['rust', 'plugin', 'code-generation'],
-    max_version: '0.0.1',
-    newest_version: '0.0.1',
     name: 'rust_mixin',
     repository: 'https://github.com/huonw/external_mixin',
     updated_at: '2015-02-27T11:52:13Z',
@@ -144,8 +138,6 @@ export default [
     homepage: 'https://github.com/huonw/external_mixin',
     id: 'external_mixin',
     keywordIds: ['python', 'ruby', 'shell', 'plugin', 'code-generation'],
-    max_version: '0.0.1',
-    newest_version: '0.0.1',
     name: 'external_mixin',
     repository: 'https://github.com/huonw/external_mixin',
     updated_at: '2015-02-27T11:51:58Z',
@@ -160,8 +152,6 @@ export default [
     homepage: 'https://github.com/huonw/external_mixin',
     id: 'external_mixin_umbrella',
     keywordIds: ['plugin', 'code-generation'],
-    max_version: '0.0.2',
-    newest_version: '0.0.2',
     name: 'external_mixin_umbrella',
     repository: 'https://github.com/huonw/external_mixin',
     updated_at: '2015-02-27T11:52:30Z',
@@ -177,8 +167,6 @@ export default [
     homepage: 'https://github.com/whatisinternet/inflector',
     id: 'Inflector',
     keywordIds: ['string', 'case', 'camel', 'snake', 'inflection'],
-    max_version: '0.1.6',
-    newest_version: '0.1.6',
     name: 'Inflector',
     repository: 'https://github.com/whatisinternet/inflector',
     updated_at: '2015-10-27T01:51:42Z',
@@ -193,8 +181,6 @@ export default [
     homepage: null,
     id: 'rs-es',
     keywordIds: ['elasticsearch', 'elastic'],
-    max_version: '0.1.17',
-    newest_version: '0.1.17',
     name: 'rs-es',
     repository: 'https://github.com/benashford/rs-es',
     updated_at: '2015-09-09T15:34:50Z',
@@ -209,8 +195,6 @@ export default [
     homepage: 'https://github.com/DaGenix/rust-crypto/',
     id: 'rust-crypto',
     keywordIds: [],
-    max_version: '0.2.34',
-    newest_version: '0.2.34',
     name: 'rust-crypto',
     repository: 'https://github.com/DaGenix/rust-crypto/',
     updated_at: '2015-10-29T01:16:17Z',
@@ -225,8 +209,6 @@ export default [
     homepage: null,
     id: 'rust-htslib',
     keywordIds: [],
-    max_version: '0.5.2',
-    newest_version: '0.5.2',
     name: 'rust-htslib',
     repository: 'https://github.com/rust-bio/rust-htslib.git',
     updated_at: '2015-11-11T00:10:43Z',
@@ -241,8 +223,6 @@ export default [
     homepage: 'https://github.com/rustless/rustless',
     id: 'rustless',
     keywordIds: [],
-    max_version: '0.8.0',
-    newest_version: '0.8.0',
     name: 'rustless',
     repository: 'https://crates.io/crates/rustless',
     updated_at: '2015-10-31T11:49:29Z',
@@ -257,8 +237,6 @@ export default [
     homepage: null,
     id: 'serde',
     keywordIds: [],
-    max_version: '0.6.1',
-    newest_version: '0.6.1',
     name: 'serde',
     repository: 'https://github.com/serde-rs/serde',
     updated_at: '2015-10-18T03:10:21Z',
@@ -273,8 +251,6 @@ export default [
     homepage: 'https://github.com/livioribeiro/rusted-cypher',
     id: 'rusted_cypher',
     keywordIds: [],
-    max_version: '0.7.1',
-    newest_version: '0.7.1',
     name: 'rusted_cypher',
     repository: 'https://github.com/livioribeiro/rusted-cypher',
     updated_at: '2015-11-07T17:26:55Z',
@@ -290,8 +266,6 @@ export default [
     homepage: null,
     id: 'zlib',
     keywordIds: [],
-    max_version: '0.0.1',
-    newest_version: '0.0.1',
     name: 'zlib',
     repository: null,
     updated_at: '2015-01-02T20:54:04Z',
@@ -307,8 +281,6 @@ export default [
     homepage: null,
     id: 'rustful',
     keywordIds: [],
-    max_version: '0.5.0',
-    newest_version: '0.5.0',
     name: 'rustful',
     repository: 'https://github.com/Ogeon/rustful',
     updated_at: '2015-09-19T21:10:27Z',
@@ -323,8 +295,6 @@ export default [
     homepage: null,
     id: 'postgres',
     keywordIds: [],
-    max_version: '0.10.1',
-    newest_version: '0.10.1',
     name: 'postgres',
     repository: 'https://github.com/sfackler/rust-postgres',
     updated_at: '2015-11-08T00:48:59Z',
@@ -339,8 +309,6 @@ export default [
     homepage: 'https://github.com/BurntSushi/quickcheck',
     id: 'quickcheck',
     keywordIds: [],
-    max_version: '0.2.24',
-    newest_version: '0.2.24',
     name: 'quickcheck',
     repository: 'https://github.com/BurntSushi/quickcheck',
     updated_at: '2015-09-20T21:53:38Z',
@@ -355,8 +323,6 @@ export default [
     homepage: 'https://github.com/BurntSushi/quickcheck',
     id: 'quickcheck_macros',
     keywordIds: [],
-    max_version: '0.2.24',
-    newest_version: '0.2.24',
     name: 'quickcheck_macros',
     repository: 'https://github.com/BurntSushi/quickcheck',
     updated_at: '2015-09-20T21:53:57Z',
@@ -372,8 +338,6 @@ export default [
     homepage: 'https://github.com/nicolas-cherel/rustlex',
     id: 'unicorn-rpc',
     keywordIds: [],
-    max_version: '0.3.1',
-    newest_version: '0.3.1',
     name: 'unicorn-rpc',
     repository: 'https://github.com/nicolas-cherel/rustlex',
     updated_at: '2015-08-25T19:15:35Z',
@@ -388,8 +352,6 @@ export default [
     homepage: null,
     id: 'nom',
     keywordIds: [],
-    max_version: '1.0.1',
-    newest_version: '1.0.1',
     name: 'nom',
     repository: 'https://github.com/Geal/nom',
     updated_at: '2015-11-22T22:00:41Z',
@@ -398,32 +360,24 @@ export default [
   {
     id: 'libc',
     name: 'libc',
-    max_version: '1.0.1',
-    newest_version: '1.0.1',
     downloads: 5169,
     recent_downloads: 69,
   },
   {
     id: 'nanomsg-sys',
     name: 'nanomsg-sys',
-    max_version: '1.0.1',
-    newest_version: '1.0.1',
     downloads: 5169,
     recent_downloads: 69,
   },
   {
     id: 'mock-build-deps',
     name: 'mock-build-deps',
-    max_version: '1.0.1',
-    newest_version: '1.0.1',
     downloads: 5169,
     recent_downloads: 69,
   },
   {
     id: 'mock-dev-deps',
     name: 'mock-dev-deps',
-    max_version: '1.0.1',
-    newest_version: '1.0.1',
     downloads: 5169,
     recent_downloads: 69,
   },