Skip to content

Commit 10c9445

Browse files
0xPoe0xPoe
committed
Clean up authors of view
1 parent 80a4529 commit 10c9445

File tree

5 files changed

+6
-30
lines changed

5 files changed

+6
-30
lines changed

‎migrations/2021-04-24-115720_remove_version_authors/down.sql

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
1-
CREATE TABLE version_authors
2-
(
3-
id SERIAL NOT NULL
4-
CONSTRAINT version_authors_pkey
5-
PRIMARY KEY,
6-
version_id INTEGER NOT NULL
7-
CONSTRAINT fk_version_authors_version_id
8-
REFERENCES versions
9-
ON DELETE CASCADED,
10-
name VARCHAR NOT NULL
1+
CREATE TABLE version_authors(
2+
id SERIAL NOT NULL CONSTRAINT version_authors_pkey PRIMARY KEY,
3+
version_id INTEGER NOT NULL CONSTRAINT fk_version_authors_version_id REFERENCES versions ON DELETE CASCADED,
4+
name VARCHAR NOT NULL
115
);
126

13-
CREATE
14-
INDEX index_version_authors_version_id
15-
ON version_authors (version_id);
7+
CREATE INDEX index_version_authors_version_id ON version_authors (version_id);

‎mirage/serializers/version.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export default BaseSerializer.extend({
2121

2222
links(version) {
2323
return {
24-
authors: `/api/v1/crates/${version.crateId}/${version.num}/authors`,
2524
dependencies: `/api/v1/crates/${version.crateId}/${version.num}/dependencies`,
2625
version_downloads: `/api/v1/crates/${version.crateId}/${version.num}/downloads`,
2726
};

‎src/views.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,6 @@ impl EncodableVersion {
624624
links: EncodableVersionLinks {
625625
dependencies: format!("/api/v1/crates/{}/{}/dependencies", crate_name, num),
626626
version_downloads: format!("/api/v1/crates/{}/{}/downloads", crate_name, num),
627-
authors: format!("/api/v1/crates/{}/{}/authors", crate_name, num),
628627
},
629628
crate_size,
630629
published_by: published_by.map(User::into),
@@ -644,7 +643,6 @@ impl EncodableVersion {
644643
pub struct EncodableVersionLinks {
645644
pub dependencies: String,
646645
pub version_downloads: String,
647-
pub authors: String,
648646
}
649647

650648
#[derive(Serialize, Deserialize, Debug)]
@@ -734,7 +732,6 @@ mod tests {
734732
links: EncodableVersionLinks {
735733
dependencies: "".to_string(),
736734
version_downloads: "".to_string(),
737-
authors: "".to_string(),
738735
},
739736
crate_size: Some(1234),
740737
published_by: None,

‎tests/mirage/crates-test.js

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,6 @@ module('Mirage | Crates', function (hooks) {
286286
downloads: 0,
287287
license: 'MIT/Apache-2.0',
288288
links: {
289-
authors: '/api/v1/crates/rand/1.0.0-beta.1/authors',
290289
dependencies: '/api/v1/crates/rand/1.0.0-beta.1/dependencies',
291290
version_downloads: '/api/v1/crates/rand/1.0.0-beta.1/downloads',
292291
},
@@ -320,7 +319,6 @@ module('Mirage | Crates', function (hooks) {
320319
downloads: 0,
321320
license: 'MIT/Apache-2.0',
322321
links: {
323-
authors: '/api/v1/crates/rand/1.0.0/authors',
324322
dependencies: '/api/v1/crates/rand/1.0.0/dependencies',
325323
version_downloads: '/api/v1/crates/rand/1.0.0/downloads',
326324
},
@@ -338,7 +336,6 @@ module('Mirage | Crates', function (hooks) {
338336
downloads: 3702,
339337
license: 'MIT',
340338
links: {
341-
authors: '/api/v1/crates/rand/1.1.0/authors',
342339
dependencies: '/api/v1/crates/rand/1.1.0/dependencies',
343340
version_downloads: '/api/v1/crates/rand/1.1.0/downloads',
344341
},
@@ -356,7 +353,6 @@ module('Mirage | Crates', function (hooks) {
356353
downloads: 7404,
357354
license: 'Apache-2.0',
358355
links: {
359-
authors: '/api/v1/crates/rand/1.2.0/authors',
360356
dependencies: '/api/v1/crates/rand/1.2.0/dependencies',
361357
version_downloads: '/api/v1/crates/rand/1.2.0/downloads',
362358
},
@@ -586,7 +582,6 @@ module('Mirage | Crates', function (hooks) {
586582
downloads: 0,
587583
license: 'MIT/Apache-2.0',
588584
links: {
589-
authors: '/api/v1/crates/rand/1.0.0/authors',
590585
dependencies: '/api/v1/crates/rand/1.0.0/dependencies',
591586
version_downloads: '/api/v1/crates/rand/1.0.0/downloads',
592587
},
@@ -604,7 +599,6 @@ module('Mirage | Crates', function (hooks) {
604599
downloads: 3702,
605600
license: 'MIT',
606601
links: {
607-
authors: '/api/v1/crates/rand/1.1.0/authors',
608602
dependencies: '/api/v1/crates/rand/1.1.0/dependencies',
609603
version_downloads: '/api/v1/crates/rand/1.1.0/downloads',
610604
},
@@ -628,7 +622,6 @@ module('Mirage | Crates', function (hooks) {
628622
downloads: 7404,
629623
license: 'Apache-2.0',
630624
links: {
631-
authors: '/api/v1/crates/rand/1.2.0/authors',
632625
dependencies: '/api/v1/crates/rand/1.2.0/dependencies',
633626
version_downloads: '/api/v1/crates/rand/1.2.0/downloads',
634627
},
@@ -680,10 +673,8 @@ module('Mirage | Crates', function (hooks) {
680673
});
681674

682675
test('returns a list of authors belonging to the specified crate version', async function (assert) {
683-
let authors = ['John Doe <[email protected]>', 'The Rust Project Developers'];
684-
685676
this.server.create('crate', { name: 'rand' });
686-
this.server.create('version', { crateId: 'rand', num: '1.0.0', _authors: authors });
677+
this.server.create('version', { crateId: 'rand', num: '1.0.0' });
687678

688679
let response = await fetch('/api/v1/crates/rand/1.0.0/authors');
689680
assert.equal(response.status, 200);
@@ -1025,7 +1016,6 @@ module('Mirage | Crates', function (hooks) {
10251016
downloads: 0,
10261017
license: 'MIT/Apache-2.0',
10271018
links: {
1028-
authors: '/api/v1/crates/bar/1.0.0/authors',
10291019
dependencies: '/api/v1/crates/bar/1.0.0/dependencies',
10301020
version_downloads: '/api/v1/crates/bar/1.0.0/downloads',
10311021
},
@@ -1043,7 +1033,6 @@ module('Mirage | Crates', function (hooks) {
10431033
downloads: 3702,
10441034
license: 'MIT',
10451035
links: {
1046-
authors: '/api/v1/crates/baz/1.0.1/authors',
10471036
dependencies: '/api/v1/crates/baz/1.0.1/dependencies',
10481037
version_downloads: '/api/v1/crates/baz/1.0.1/downloads',
10491038
},

‎tests/mirage/me-test.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ module('Mirage | /me', function (hooks) {
236236
downloads: 0,
237237
license: 'MIT/Apache-2.0',
238238
links: {
239-
authors: '/api/v1/crates/foo/1.2.3/authors',
240239
dependencies: '/api/v1/crates/foo/1.2.3/dependencies',
241240
version_downloads: '/api/v1/crates/foo/1.2.3/downloads',
242241
},

0 commit comments

Comments
 (0)