-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Warn when generated search index is huge #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some more thoughts from when I was investigating this:
|
Few quick thoughts:
|
That can be worked-around by setting
I don't think that is the main reason, removing ~all body content [0] reduce the RFC index from 38MB to 35MB.
I'm not familiar with There are currently ~4500 unique URLs referenced in the index, the most common one occurs almost 1000 times, the least common ones occur 6 times. Not counting quotation marks, just these URLs make up about 21MB. [0] |
Here's the effect of the changes in #707 on page load performance for the rfcs book. The page load stats were recorded using the Firefox dev tools in "Good 3G" throttling and simple-http-server with GZip.
* searchindex.js was loaded before a few page resources, so it's included in the Page Load numbers Don't know how much parse time would be spent on the JSON on a phone, but I think the above numbers are acceptable if imperfect. |
While iOS still crashes, this looks much better already, thanks a lot! The performance analysis tools offered by Chrome are also much happier :D |
cf. rust-lang/rfcs#2469
The text was updated successfully, but these errors were encountered: