Skip to content

Add compress_attributes.js transform #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rreusser opened this issue Apr 5, 2017 · 5 comments
Closed

Add compress_attributes.js transform #5

rreusser opened this issue Apr 5, 2017 · 5 comments

Comments

@rreusser
Copy link
Owner

rreusser commented Apr 5, 2017

To trim attr descriptions.

@etpinard
Copy link
Collaborator

etpinard commented Apr 7, 2017

After thinking about this some more, maybe plotly.js should compress its attributes by default. That is, we should list the compress attribute transform in its package.json.

At the time of the first plotly.js FOSS release, I wasn't aware of the --ignore-transform=MODULE browserify option. I'm thinking by default we should 🔪 the attribute descriptions by default and allow users to optionally include them in custom builds. Thoughts?

@rreusser
Copy link
Owner Author

rreusser commented Apr 7, 2017

Strong agreement. Was wondering about this as I realized my custom bundles are giant because I'm not bothering to pull in that transform.

@etpinard
Copy link
Collaborator

etpinard commented Apr 7, 2017

Strong agreement.

Awesome. I'll put that on my todo list. Feel free to close this issue 👍

@rreusser
Copy link
Owner Author

rreusser commented Apr 7, 2017

No prob. Are you able to close the issue? I can, but curious if non-org-owner push permissions (there is no org) include managing other functions.

@etpinard
Copy link
Collaborator

etpinard commented Apr 7, 2017

... I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants