Tip of currently selected branch rendered outside of history view

[cbrunnkvist]

Whenever I select a branch, local or remote, the history view scrolls to one-commit-below the most recent commit. The effect is that I cant see it but have to scroll the history view up. It makes navigating and identifying branches kind of hopeless.

N.b. This issue only manifests itself when the history pane is showing "All branches".

Expected

Actual

[cbrunnkvist]

This bug is only present in the rowanj fork of GitX AFAICT.

[ghost]

This is fixed by my change in #399.

[cbrunnkvist]

Sweet. I suspected that ticket and mine were perhaps talking about the same, or similar problem, but with different wording. Prior to posting this I downloaded your fork and tried to build it but build.py failed at objective-git whatever that library is called. I didn't spend any time trying to fix it though. :)

Do you have a finished build somewhere?

[ghost]

You most likely forgot the bootstrap step. It should build cleanly if you follow the instructions in the Development section of the readme.

[cbrunnkvist]

Correct, I missed one step of the bootstrap section.

Indeed, #399 corrects the bug!

[mpfeiffermway]

This issue also affects tags, i.e. when I select a tag the history entry for the selected tag is always one above the history entry that is displayed at the top of the list.

Kind of annoying when you try to review releases (by clicking on their tags) and always have to scroll up after selecting a tag. Can anyone confirm that #399 also fixes this?

[cbrunnkvist]

@mpfeiffermway affirmative: the adjustScroll method works the same for both cases, and in addition I just tested it and yes it brings tags into view properly as well. 👍