Skip to content

Commit 7f6a0be

Browse files
committed
Only release references in unsubscribe
We decided it's better to leave it to the caller when it's appropriate to release, cf. ReactiveX#1
1 parent e0fb980 commit 7f6a0be

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public void onCompleted() {
7979
observerRef.onCompleted();
8080
} else {
8181
log("onComplete: target component released or detached; dropping message");
82-
releaseReferences();
8382
}
8483
}
8584

@@ -89,7 +88,6 @@ public void onError(Throwable e) {
8988
observerRef.onError(e);
9089
} else {
9190
log("onError: target component released or detached; dropping message");
92-
releaseReferences();
9391
}
9492
}
9593

@@ -99,7 +97,6 @@ public void onNext(T args) {
9997
observerRef.onNext(args);
10098
} else {
10199
log("onNext: target component released or detached; dropping message");
102-
releaseReferences();
103100
}
104101
}
105102
});

0 commit comments

Comments
 (0)