fix #24: use custom nsc reporter in neg tests

Author: bishabosha

src/tastytest/scala/tools/tastytest/TastyTest.scala

@@ -4,6 +4,7 @@ import scala.collection.mutable
 import scala.jdk.CollectionConverters._
 import scala.tools.nsc
 import scala.util.{ Try, Success, Failure }
+import scala.util.chaining._
 
 import dotty.tools.dotc
 import dotc.reporting.{ Reporter => DottyReporter }
@@ -16,6 +17,7 @@ import jl.reflect.Modifier
 import CommandLineParsers._
 import SourceKind._
 import Files._
+import scala.tools.nsc.{Global, Settings, reporters}, reporters.ConsoleReporter
 
 object TastyTest {
 
@@ -166,15 +168,30 @@ object TastyTest {
   }
 
   private def scalac(out: String, dottyLibrary: String, sources: String*): Boolean = {
+
+    def runCompile(global: Global): Boolean = {
+      global.reporter.reset()
+      new global.Run() compile sources.toList
+      !global.reporter.hasErrors
+    }
+
+    def newCompiler(args: String*): Global =
+      fromSettings(new Settings().tap(_ processArguments(args.toList, true)))
+
+    def fromSettings(settings: Settings): Global =
+      Global(settings, new ConsoleReporter(settings).tap(_.shortname = true))
+
+    def compile(args: String*) =
+      Try(runCompile(newCompiler(args: _*))).getOrElse(false)
+
     sources.isEmpty || {
-      val args = Array(
+      compile(
         "-d", out,
         "-classpath", classpaths(out, dottyLibrary),
         "-deprecation",
         "-Xfatal-warnings",
         "-usejavacp"
-      ) ++ sources
-      Try(nsc.Main.process(args)).getOrElse(false)
+      )
     }
   }
 

test/tasty/neg-false/src-2/NewJVMEnv.check

@@ -1,4 +1,3 @@
-/Users/jamie/workspace/scala/test/tasty/neg-false/src-2/NewJVMEnv_fail.scala:9: error: class type required but tastytest.printing#AnyHash with tastytest.printing#AnyClassName found
+NewJVMEnv_fail.scala:9: error: class type required but tastytest.printing#AnyHash with tastytest.printing#AnyClassName found
   new Env.JVMEnv {} // error: class type required but tastytest.printing#AnyHash with tastytest.printing#AnyClassName found
           ^
-1 error

test/tasty/neg/src-2/SColourOps.check

@@ -1,7 +1,5 @@
-/Users/jamie/workspace/scala/test/tasty/neg/src-2/SColourOps_fail.scala:6: warning: match may not be exhaustive.
+SColourOps_fail.scala:6: warning: match may not be exhaustive.
 It would fail on the following inputs: Blue, CMYK(_, _, _, _), Green, RGB(_, _, _)
     def red: Int = c match { // error: non-exhaustive
                    ^
 error: No warnings can be incurred under -Werror.
-1 warning
-1 error

test/tasty/neg/src-2/SColourOpsUnreachable.check

@@ -1,6 +1,4 @@
-/Users/jamie/workspace/scala/test/tasty/neg/src-2/SColourOpsUnreachable_fail.scala:8: warning: unreachable code
+SColourOpsUnreachable_fail.scala:8: warning: unreachable code
       case SColour.Blue => -1 // error: unreachable
                            ^
 error: No warnings can be incurred under -Werror.
-1 warning
-1 error

test/tasty/neg/src-2/TestDeprecations.check

@@ -1,9 +1,7 @@
-/Users/jamie/workspace/scala/test/tasty/neg/src-2/TestDeprecations_fail.scala:5: warning: method unused in class Old is deprecated
+TestDeprecations_fail.scala:5: warning: method unused in class Old is deprecated
   def test1 = new Deprecations.Old().unused() // error: unused is deprecated
                                      ^
-/Users/jamie/workspace/scala/test/tasty/neg/src-2/TestDeprecations_fail.scala:6: warning: method completelyUseless in class Old is deprecated: this is useless
+TestDeprecations_fail.scala:6: warning: method completelyUseless in class Old is deprecated: this is useless
   def test2 = new Deprecations.Old().completelyUseless() // error: completelyUseless is deprecated: this is useless
                                      ^
 error: No warnings can be incurred under -Werror.
-2 warnings
-1 error

test/tasty/neg/src-2/TestHello.check

@@ -1,7 +1,6 @@
 error: Scala 2 incompatible TASTy signature of HelloWorld.tasty in object HelloWorld: inline val msg with non-constant type String
-/Users/jamie/workspace/scala/test/tasty/neg/src-2/TestHello_fail.scala:5: error: type mismatch;
+TestHello_fail.scala:5: error: type mismatch;
  found   : helloworld.TestHello.helloworld.type (with underlying type String)
  required: helloworld.HelloWorld.msg1.type
   HelloWorld.acceptsOnlyMsg1(helloworld)
                              ^
-2 errors

test/tasty/neg/src-2/TestIntent.check

@@ -1,2 +1 @@
 error: Scala 2 incompatible TASTy signature of Position.tasty in object Position: unsupported Scala 3 flags on method here: inline | <tastymacro>
-1 error