Skip to content

Node warning 1335254 using node v20.12.0 #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aspeddro opened this issue Mar 30, 2025 · 4 comments · Fixed by #7379
Closed

Node warning 1335254 using node v20.12.0 #7372

aspeddro opened this issue Mar 30, 2025 · 4 comments · Fixed by #7379
Assignees

Comments

@aspeddro
Copy link
Contributor

./cli/rescript.js build --help command print node warning 1335254

(node:1335254) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Usage: rescript build <options> -- <ninja_options>

`rescript build` builds the project with dependencies

`rescript build -- -h` for Ninja options (internal usage only; unstable)

Options:
  -w           Watch mode
  -ws          [host]:port set up host & port for WebSocket build notifications
  -verbose     Set the output to be verbose
  -with-deps   *deprecated* This is the default behavior now. This option will be removed in a future release
  -warn-error  Warning numbers and whether to turn them into errors, e.g., "+8+32-102"

Node v20.19.0 (version used on CI) don't print this warning

@aspeddro
Copy link
Contributor Author

aspeddro commented Mar 30, 2025

We should update engines.node in package.json?

@cometkim
Copy link
Member

It won't cause any real problems as it has been stabilized since then without any changes.

@cometkim
Copy link
Member

it has been stabilized since then without any changes.

It is v23.1.0 according to the docs https://nodejs.org/api/esm.html#json-modules

But I couldn't find its back-porting history

@cometkim
Copy link
Member

We can change it to use node:fs api to avoid the warning anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants