More untagged variant output inefficiency #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cknitt opened this issue Oct 31, 2024 · 0 comments

Member

cknitt commented Oct 31, 2024

Followup to #7138:

Consider the output here:
https://github.com/rescript-lang/rescript-compiler/blob/41e2fd64dc166a6f092d65ddbf607d4b2878f0b4/tests/tests/src/UntaggedVariants.mjs#L403

          if (match$3 === undefined || match$3 === null || match$3 === false || match$3 === true) {
            console.log("Nope...");
            return;
          }
          if (typeof match$3 === "string" && match$3 === "My name is") {

could just be

          if (match$3 === "My name is") {

cristianoc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment