Skip to content

Commit c048e26

Browse files
authored
Disable syntax benchmark warnings in PRs for now (#7380)
1 parent 6bb7e0a commit c048e26

File tree

1 file changed

+29
-27
lines changed

1 file changed

+29
-27
lines changed

.github/workflows/ci.yml

+29-27
Original file line numberDiff line numberDiff line change
@@ -373,33 +373,35 @@ jobs:
373373
if: matrix.benchmarks
374374
run: ./_build/install/default/bin/syntax_benchmarks | tee tests/benchmark-output.json
375375

376-
- name: Restore previous benchmark data
377-
if: matrix.benchmarks
378-
uses: actions/cache/restore@v4
379-
with:
380-
path: ./tests/benchmark-cache
381-
key: syntax-benchmark-v1
382-
383-
- name: Create new benchmark data and comment on alert
384-
# Do not run for PRs created from other repos as those won't be able to write to the pull request
385-
if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
386-
uses: benchmark-action/github-action-benchmark@v1
387-
with:
388-
name: Syntax Benchmarks
389-
tool: customSmallerIsBetter
390-
output-file-path: tests/benchmark-output.json
391-
external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
392-
github-token: ${{ secrets.GITHUB_TOKEN }}
393-
alert-threshold: "105%"
394-
comment-always: false
395-
comment-on-alert: true
396-
397-
- name: Save benchmark data as new baseline
398-
if: matrix.benchmarks && github.ref == 'refs/heads/master'
399-
uses: actions/cache/save@v4
400-
with:
401-
path: ./tests/benchmark-cache
402-
key: syntax-benchmark-v1
376+
# Benchmarking is disabled for now because of inconsistent run times on different runners
377+
#
378+
# - name: Restore previous benchmark data
379+
# if: matrix.benchmarks
380+
# uses: actions/cache/restore@v4
381+
# with:
382+
# path: ./tests/benchmark-cache
383+
# key: syntax-benchmark-v1
384+
385+
# - name: Create new benchmark data and comment on alert
386+
# # Do not run for PRs created from other repos as those won't be able to write to the pull request
387+
# if: ${{ matrix.benchmarks && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.repository.full_name) }}
388+
# uses: benchmark-action/github-action-benchmark@v1
389+
# with:
390+
# name: Syntax Benchmarks
391+
# tool: customSmallerIsBetter
392+
# output-file-path: tests/benchmark-output.json
393+
# external-data-json-path: ./tests/benchmark-cache/benchmark-data.json
394+
# github-token: ${{ secrets.GITHUB_TOKEN }}
395+
# alert-threshold: "105%"
396+
# comment-always: false
397+
# comment-on-alert: true
398+
399+
# - name: Save benchmark data as new baseline
400+
# if: matrix.benchmarks && github.ref == 'refs/heads/master'
401+
# uses: actions/cache/save@v4
402+
# with:
403+
# path: ./tests/benchmark-cache
404+
# key: syntax-benchmark-v1
403405

404406
- name: Build playground compiler
405407
if: matrix.build_playground

0 commit comments

Comments
 (0)