rename function

Author: cometkim

jscomp/ext/ext_ident.ml

@@ -140,15 +140,15 @@ let is_uident name =
     | _ -> false
   else false
 
-let is_exotic name =
+let is_uppercase_exotic name =
   let len = String.length name in
   len >= 3
   && name.[0] = '\\'
   && name.[1] = '\"'
   && name.[len - 1] = '\"'
 
-let unwrap_exotic name =
-  if is_exotic name then
+let unwrap_uppercase_exotic name =
+  if is_uppercase_exotic name then
    let len = String.length name in
    String.sub name 2 (len - 3)
   else name

jscomp/ext/ext_ident.mli

@@ -50,9 +50,9 @@ val make_unused : unit -> Ident.t
 
 val is_uident : string -> bool
 
-val is_exotic : string -> bool
+val is_uppercase_exotic : string -> bool
 
-val unwrap_exotic : string -> string
+val unwrap_uppercase_exotic : string -> string
 
 (**
    Invariant: if name is not converted, the reference should be equal

jscomp/syntax/src/res_ast_debugger.ml

@@ -54,7 +54,8 @@ module SexpAst = struct
     | [] -> [Sexp.list []]
     | items -> List.map f items
 
-  let string txt = Sexp.atom ("\"" ^ Ext_ident.unwrap_exotic txt ^ "\"")
+  let string txt =
+    Sexp.atom ("\"" ^ Ext_ident.unwrap_uppercase_exotic txt ^ "\"")
 
   let char c = Sexp.atom ("'" ^ Char.escaped c ^ "'")
 

jscomp/syntax/src/res_printer.ml

@@ -399,7 +399,7 @@ let classifyIdentContent ?(allowUident = false) ?(allowHyphen = false) txt =
     loop 0
 
 let printIdentLike ?allowUident ?allowHyphen txt =
-  let txt = Ext_ident.unwrap_exotic txt in
+  let txt = Ext_ident.unwrap_uppercase_exotic txt in
   match classifyIdentContent ?allowUident ?allowHyphen txt with
   | ExoticIdent -> Doc.concat [Doc.text "\\\""; Doc.text txt; Doc.text "\""]
   | NormalIdent -> Doc.text txt
@@ -433,7 +433,7 @@ let printPolyVarIdent txt =
   (* numeric poly-vars don't need quotes: #644 *)
   if isValidNumericPolyvarNumber txt then Doc.text txt
   else
-    let txt = Ext_ident.unwrap_exotic txt in
+    let txt = Ext_ident.unwrap_uppercase_exotic txt in
     match classifyIdentContent ~allowUident:true txt with
     | ExoticIdent -> Doc.concat [Doc.text "\""; Doc.text txt; Doc.text "\""]
     | NormalIdent -> (

jscomp/syntax/src/res_scanner.ml

@@ -310,7 +310,7 @@ let scanExoticIdentifier scanner =
   let ident =
     (String.sub [@doesNotRaise]) scanner.src startOff (scanner.offset - startOff)
   in
-  let name = Ext_ident.unwrap_exotic ident in
+  let name = Ext_ident.unwrap_uppercase_exotic ident in
   if name = String.empty then (
     let endPos = position scanner in
     scanner.err ~startPos ~endPos