Fix issue where create interface file would not work with certain JSX V4 components

Author: cristianoc

CHANGELOG.md

@@ -31,6 +31,8 @@
 
 - Fix file location in Document Symbols response. https://github.com/rescript-lang/rescript-vscode/issues/629
 
+- Fix issue where create interface file would not work with certain JSX V4 components https://github.com/rescript-lang/rescript-vscode/issues/617
+
 ## v1.8.2
 
 #### :rocket: New Feature

analysis/src/CreateInterface.ml

@@ -246,11 +246,7 @@ let printSignature ~extractor ~signature =
       :: Sig_value (makeId (* make *), makeValueDesc)
       :: rest
       when Ident.name propsId = "props"
-           && getComponentTypeV4 makeValueDesc.val_type <> None
-           &&
-           match recordRepresentation with
-           | Record_optional_labels _ -> true
-           | _ -> labelDecls = [] (* empty record *) ->
+           && getComponentTypeV4 makeValueDesc.val_type <> None ->
       (* PPX V4 component declaration:
          type props = {...}
          let v = ...

analysis/tests/src/expected/JsxV4.res.txt

@@ -26,7 +26,7 @@ module MM: {
   let make: unit => React.element
 }
 module Other: {
-  type props<'name> = {name: 'name}
-  let make: props<string> => React.element
+  @react.component
+  let make: (~name: string) => React.element
 }