Skip to content

TypeScript types should be moved to DefinitelyTyped or ported to TypeScript #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickserv opened this issue Aug 15, 2019 · 3 comments
Closed

Comments

@nickserv
Copy link
Contributor

nickserv commented Aug 15, 2019

This is pretty much the same as reduxjs/redux#3500, so please read that for my explanation and the pending discussion.

Ultimately the decision for Reselect depends on how comfortable the maintainers are with TypeScript and if they want to support it directly (is so port, if not use DefinitelyTyped and remove the types from this package).

@MichaelDeBoey
Copy link

MichaelDeBoey commented Aug 18, 2019

@markerikson @timdorr react-testing-library moved their typings to DT, but added them as a dependency to their package. Could be an interesting move for reselect/redux-thunk/... too if you want to keep them in JS.
https://blog.johnnyreilly.com/2019/08/symbiotic-definitely-typed.html

@nickserv
Copy link
Contributor Author

In my opinion, it's better to break back compatibility and allow more freedom in versioning the peer dependency.

@markerikson
Copy link
Contributor

Don't see them being moved to DT at this point, and if anything we oughta rewrite this in TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants