adjust tests, try to provoke error

Author: phryneas

.github/workflows/test-codegen.yml

@@ -6,27 +6,18 @@ defaults:
   run:
     working-directory: ./packages/rtk-query-codegen-openapi
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - 'packages/rtk-query-codegen-openapi/**'
+  pull_request:
+    paths:
+      - 'packages/rtk-query-codegen-openapi/**'
 
 jobs:
-  changes:
-    name: Check for changes
-    runs-on: ubuntu-latest
-    outputs:
-      codegen: ${{ steps.filter.outputs.codegen }}
-    steps:
-      - uses: actions/checkout@v2
-      - uses: dorny/paths-filter@v2
-        id: filter
-        with:
-          filters: |
-            codegen:
-              - 'packages/rtk-query-codegen-openapi/**'
-
   build:
-    needs: changes
-    if: ${{ needs.changes.outputs.codegen == 'true' }}
-
     runs-on: ubuntu-latest
 
     strategy:

.github/workflows/tests.yml

@@ -1,28 +1,20 @@
 name: CI
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - 'packages/toolkit/**'
+  pull_request:
+    paths:
+      - 'packages/toolkit/**'
+
 defaults:
   run:
     working-directory: ./packages/toolkit
 
 jobs:
-  changes:
-    name: Check for changes
-    runs-on: ubuntu-latest
-    outputs:
-      toolkit: ${{ steps.filter.outputs.toolkit }}
-    steps:
-      - uses: actions/checkout@v2
-      - uses: dorny/paths-filter@v2
-        id: filter
-        with:
-          filters: |
-            toolkit:
-              - 'packages/toolkit/**'
-
   build:
-    needs: changes
-    if: ${{ needs.changes.outputs.toolkit == 'true' }}
-
     name: Lint, Test, Build & Pack on Node ${{ matrix.node }}
 
     runs-on: ubuntu-latest

packages/toolkit/src/createSlice.ts

@@ -235,7 +235,9 @@ export type ValidateSliceCaseReducers<
       ? {
           prepare(...a: never[]): Omit<A, 'type'>
         }
-      : ACR[T]
+      : {}
+    // this should still error in 4.8 - the fix woule be
+    // : ACR[T]
   }
 
 function getType(slice: string, actionKey: string): string {
@@ -268,8 +270,10 @@ export function createSlice<
     typeof process !== 'undefined' &&
     process.env.NODE_ENV === 'development'
   ) {
-    if(options.initialState === undefined) {
-      console.error('You must provide an `initialState` value that is not `undefined`. You may have misspelled `initialState`')
+    if (options.initialState === undefined) {
+      console.error(
+        'You must provide an `initialState` value that is not `undefined`. You may have misspelled `initialState`'
+      )
     }
   }
 

packages/toolkit/src/tests/createSlice.typetest.ts

@@ -9,8 +9,8 @@ import type {
   PayloadAction,
   SliceCaseReducers,
   ValidateSliceCaseReducers,
-} from '@reduxjs/toolkit'
-import { createAction, createSlice } from '@reduxjs/toolkit'
+} from '..'
+import { createAction, createSlice } from '..'
 import { expectType } from './helpers'
 
 /*
@@ -58,7 +58,7 @@ const value = actionCreators.anyKey
     reducers: {
       increment: (state: number, action) => {
         // @ts-expect-error
-        expect<string>(state)
+        expectType<string>(state)
         return state + action.payload
       },
       decrement: (state: number, action) => state - action.payload,
@@ -101,7 +101,7 @@ const value = actionCreators.anyKey
         { payload = 1 }: PayloadAction<number | undefined>
       ) => {
         // @ts-expect-error
-        expect<string>(state)
+        expectType<string>(state)
         return state - payload
       },
 

packages/toolkit/tsconfig.test.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../toolkit/tsconfig.base.json",
+  "extends": "./tsconfig.base.json",
   "compilerOptions": {
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,