Skip to content

Commit 3ca1d6a

Browse files
gengjiawenfacebook-github-bot
authored andcommitted
bump android gradle to 3.1.4 (#20767)
Summary: Bump android gradle plugin to 3.1.4. We have been stay to 2.x too long. With 3.x we can have instant run and great performance and new features brought by google. Also thanks to CFKevinRef great pr to make this possible. pass all current ci. I have also tested RNTester release version works without crash. facebook/react-native#17967. [GENERAL] [ANDROID] [FEATURE] - bump android gradle to 3.1.4 Pull Request resolved: facebook/react-native#20767 Differential Revision: D9437576 Pulled By: hramos fbshipit-source-id: 6084056a1390582a75a879918f2538b0480f6299
1 parent 3a0844a commit 3ca1d6a

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

templates/HelloWorld/android/app/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ android {
137137
}
138138

139139
dependencies {
140-
compile fileTree(dir: "libs", include: ["*.jar"])
141-
compile "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
142-
compile "com.facebook.react:react-native:+" // From node_modules
140+
implementation fileTree(dir: "libs", include: ["*.jar"])
141+
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
142+
implementation "com.facebook.react:react-native:+" // From node_modules
143143
}
144144

145145
// Run this once to be able to run the application with BUCK

templates/HelloWorld/android/build.gradle

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@
33
buildscript {
44
repositories {
55
jcenter()
6-
maven {
7-
url 'https://maven.google.com/'
8-
name 'Google'
9-
}
6+
google()
107
}
118
dependencies {
12-
classpath 'com.android.tools.build:gradle:2.3.3'
9+
classpath 'com.android.tools.build:gradle:3.1.4'
1310

1411
// NOTE: Do not place your application dependencies here; they belong
1512
// in the individual module build.gradle files
@@ -24,10 +21,7 @@ allprojects {
2421
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
2522
url "$rootDir/../node_modules/react-native/android"
2623
}
27-
maven {
28-
url 'https://maven.google.com/'
29-
name 'Google'
30-
}
24+
google()
3125
}
3226
}
3327

0 commit comments

Comments
 (0)