-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Keyboard input Tab + Shift escapes Modal's focus #6782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you provide an updated sandbox link? The current link says "not found" |
Hi can you please try it again. I realized it was in my drafts and couldn't be seen by someone else. Thanks! Link https://codesandbox.io/p/sandbox/youthful-grothendieck-fzppl5 |
When you shift tab, the base modal captures the key press and ends up focusing on the modal dialog div, although that's been set with a tabindex of -1: Seems like this should be targeting the last focusable element within the modal though. @jquense was there a reason for focusing on the modal dialog div? |
@jquense , our 508 team is holding us on this issue. They are saying, either the focus is "trapped" in the dialog OR the dialog "act as the entire document" and allows the focus to cycle through the browser UI (Issue #6579). I just argued the latter with our 508 team based on your response in Issue #6579. I think the title of this issue is misleading since the focus doesn't really escape the dialog, it just gets held at the dialog element as @kyletsang mentions |
Should be possible but a bit tricky, I think I started to try and fix this upstream but didn't have the time to finish |
Any updates on this bug(fix) @jquense? For accessibility reasons we need the modal to behave the same way when using |
Hey @Dev-Oli i'm not working on this, if you want to take a stab at it go for it. PRs are welcome! This isn't super high priority for us as we've had the currently implementation validated by a11y auditors before and while not the most ideal, it's not really a problem in practice (according to them). I appreciate that your team feels differently but we are just short on time ! |
Prerequisites
Describe the bug
With the React Bootstrap modal open, attempt to move around with your keyboard using
Shift + Tab
. The elements from the background of the modal which should be out of focus start getting focused.Expected behavior
Using
Shift + Tab
should keep the focus on the elements within the modalTo Reproduce
No response
Reproducible Example
https://codesandbox.io/p/sandbox/youthful-grothendieck-fzppl5
Screenshots
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What version of React-Bootstrap are you using?
2.7.2
What version of Bootstrap are you using?
5.2.3
Additional context
No response
The text was updated successfully, but these errors were encountered: