Mandatory context on NewRedisStore

Author: rbcervilla

README.md

@@ -10,6 +10,7 @@ It uses [`go-redis v8`](https://github.com/go-redis/redis) as client to connect
 package main
 
 import (
+    "context"
     "github.com/go-redis/redis/v8"
     "github.com/gorilla/sessions"
     "github.com/rbcervilla/redisstore/v8"
@@ -25,7 +26,7 @@ func main() {
     })
 
     // New default RedisStore
-    store, err := redisstore.NewRedisStore(client)
+    store, err := redisstore.NewRedisStore(context.Background(), client)
     if err != nil {
         log.Fatal("failed to create redis store: ", err)
     }

redisstore.go

@@ -33,24 +33,7 @@ type RedisStore struct {
 type KeyGenFunc func() (string, error)
 
 // NewRedisStore returns a new RedisStore with default configuration
-func NewRedisStore(client redis.UniversalClient) (*RedisStore, error) {
-
-	rs := &RedisStore{
-		options: sessions.Options{
-			Path:   "/",
-			MaxAge: 86400 * 30,
-		},
-		client:     client,
-		keyPrefix:  "session:",
-		keyGen:     generateRandomKey,
-		serializer: GobSerializer{},
-	}
-
-	return rs, rs.client.Ping(context.TODO()).Err()
-}
-
-// NewRedisStoreWithContext returns a new RedisStore with default configuration
-func NewRedisStoreWithContext(ctx context.Context, client redis.UniversalClient) (*RedisStore, error) {
+func NewRedisStore(ctx context.Context, client redis.UniversalClient) (*RedisStore, error) {
 
 	rs := &RedisStore{
 		options: sessions.Options{

redisstore_test.go

@@ -1,6 +1,7 @@
 package redisstore
 
 import (
+	"context"
 	"github.com/go-redis/redis/v8"
 	"github.com/gorilla/sessions"
 	"net/http"
@@ -18,7 +19,7 @@ func TestNew(t *testing.T) {
 		Addr: redisAddr,
 	})
 
-	store, err := NewRedisStore(client)
+	store, err := NewRedisStore(context.Background(), client)
 	if err != nil {
 		t.Fatal("failed to create redis store", err)
 	}
@@ -43,7 +44,7 @@ func TestOptions(t *testing.T) {
 		Addr: redisAddr,
 	})
 
-	store, err := NewRedisStore(client)
+	store, err := NewRedisStore(context.Background(), client)
 	if err != nil {
 		t.Fatal("failed to create redis store", err)
 	}
@@ -71,7 +72,7 @@ func TestSave(t *testing.T) {
 		Addr: redisAddr,
 	})
 
-	store, err := NewRedisStore(client)
+	store, err := NewRedisStore(context.Background(), client)
 	if err != nil {
 		t.Fatal("failed to create redis store", err)
 	}
@@ -100,7 +101,7 @@ func TestDelete(t *testing.T) {
 		Addr: redisAddr,
 	})
 
-	store, err := NewRedisStore(client)
+	store, err := NewRedisStore(context.Background(), client)
 	if err != nil {
 		t.Fatal("failed to create redis store", err)
 	}