Skip to content

logging.isEnabledFor should return bool #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skrap opened this issue Nov 14, 2016 · 1 comment
Closed

logging.isEnabledFor should return bool #688

skrap opened this issue Nov 14, 2016 · 1 comment

Comments

@skrap
Copy link

skrap commented Nov 14, 2016

logging.isEnabledFor should return bool. Currently typeshed has it returning None for both python 2 and 3.

Suggested:
def isEnabledFor(self, lvl: int) -> bool: ...

This is my first typeshed bug, so hopefully I'm not messing it up too badly!

@ambv
Copy link
Contributor

ambv commented Nov 30, 2016

Fixed by #716 and #721.

@ambv ambv closed this as completed Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants