Skip to content

Commit c58a93b

Browse files
authored
mypy_primer: speed up, clean up (#4730)
We use tee and no longer try to delete the file based on exit code, since we use data.trim now. mypy_primer started failing silently because of changes in aiohttp, so now we'll fail if the exit codes are not 0 or 1. Note mypy_primer has --project-date to get around the problem of breaking changes in projects, but I want to try and keep mypy_primer up to date / get a feel for how bad this problem actually is. Co-authored-by: hauntsaninja <>
1 parent 3f35c92 commit c58a93b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/mypy_primer.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ jobs:
3535
git rev-list --format=%s --max-count=1 upstream_master
3636
echo ''
3737
cd ..
38-
( mypy_primer --new v0.790 --old v0.790 --custom-typeshed-repo typeshed_to_test --new-typeshed $COMMIT --old-typeshed upstream_master -o concise > diff.txt && rm diff.txt ) || true
39-
cat diff.txt || true
38+
( mypy_primer --new 0.790 --old 0.790 --custom-typeshed-repo typeshed_to_test --new-typeshed $COMMIT --old-typeshed upstream_master -o concise | tee diff.txt ) || [ $? -eq 1 ]
4039
- name: Post comment
4140
uses: actions/github-script@v3
4241
with:

0 commit comments

Comments
 (0)