gh-121035: Further improve logging flow diagram with respect to dark/light modes. (GH-121265)

vsajip · web-flow · commit 089835469d5e · 2024-07-02T18:57:34.000+01:00
diff --git a/Doc/howto/logging.rst b/Doc/howto/logging.rst
@@ -403,11 +403,13 @@ following diagram.
      function updateBody(theme) {
         let elem = document.body;
 
+        elem.classList.remove('dark-theme');
+        elem.classList.remove('light-theme');
         if (theme === 'dark') {
             elem.classList.add('dark-theme');
         }
-        else {
-            elem.classList.remove('dark-theme');
+        else if (theme === 'light') {
+            elem.classList.add('light-theme');
         }
      }
 
diff --git a/Doc/howto/logging_flow.svg b/Doc/howto/logging_flow.svg
@@ -46,6 +46,7 @@
         filter: invert(100%) hue-rotate(180deg) saturate(1.25);
       }
     }
+    /* These rules are for when the theme selector is used, perhaps in contrast to the browser theme. */
     body.dark-theme polygon, body.dark-theme rect, body.dark-theme polyline, body.dark-theme line {
       stroke: #ffffff;
     }
@@ -55,6 +56,15 @@
     body.dark-theme text {
       fill: #ffffff;
     }
+    body.light-theme polygon, body.light-theme rect, body.light-theme polyline, body.light-theme line {
+      stroke: #000000;
+    }
+    body.light-theme polygon.filled {
+      fill: #000000;
+    }
+    body.light-theme text {
+      fill: #000000;
+    }
   </style>
 
   <defs />

Original file line number	Diff line number	Diff line change
`@@ -403,11 +403,13 @@ following diagram.`
`403`	`403`	`function updateBody(theme) {`
`404`	`404`	`let elem = document.body;`
`405`	`405`
	`406`	`+ elem.classList.remove('dark-theme');`
	`407`	`+ elem.classList.remove('light-theme');`
`406`	`408`	`if (theme === 'dark') {`
`407`	`409`	`elem.classList.add('dark-theme');`
`408`	`410`	`}`
`409`		`- else {`
`410`		`- elem.classList.remove('dark-theme');`
	`411`	`+ else if (theme === 'light') {`
	`412`	`+ elem.classList.add('light-theme');`
`411`	`413`	`}`
`412`	`414`	`}`
`413`	`415`