Merge pull request #429 from jyggen/add-failing-list-test

Add failing test for lists as additional properties

Author: p1c2u

openapi_core/unmarshalling/schemas/unmarshallers.py

@@ -181,7 +181,9 @@ class ArrayUnmarshaller(ComplexUnmarshaller):
 
     @property
     def items_unmarshaller(self) -> "BaseSchemaUnmarshaller":
-        return self.unmarshallers_factory.create(self.schema / "items")
+        # sometimes we don't have any schema i.e. free-form objects
+        items_schema = self.schema.get("items", Spec.from_dict({}))
+        return self.unmarshallers_factory.create(items_schema)
 
     def __call__(self, value: Any) -> Optional[List[Any]]:
         value = super().__call__(value)

tests/unit/unmarshalling/test_unmarshal.py

@@ -816,3 +816,14 @@ def test_write_only_properties_invalid(self, unmarshaller_factory):
             unmarshaller_factory(spec, context=UnmarshalContext.RESPONSE)(
                 {"id": 10}
             )
+
+    def test_additional_properties_list(self, unmarshaller_factory):
+        schema = {"type": "object"}
+        spec = Spec.from_dict(schema)
+
+        result = unmarshaller_factory(spec, context=UnmarshalContext.RESPONSE)(
+            {"user_ids": [1, 2, 3, 4]}
+        )
+
+        assert is_dataclass(result)
+        assert result.user_ids == [1, 2, 3, 4]