Skip to content

Regression on javascript extraction on v2.3 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsakkis opened this issue Jun 8, 2016 · 2 comments
Closed

Regression on javascript extraction on v2.3 #416

gsakkis opened this issue Jun 8, 2016 · 2 comments
Labels
area/messages bug

Comments

@gsakkis
Copy link

gsakkis commented Jun 8, 2016

It seems like after upgrading to 2.3, some strings in minified javascript files are not extracted anymore. Is this a known bug?
@gitmate-bot gitmate-bot added the bug label Jun 8, 2016
@akx
Copy link
Member

akx commented Jun 9, 2016

Not a bug I'm aware of -- sorry!

Do you have an example of a JavaScript file which fails extraction (or preferably a minimal test case that reproduces the problem), and what the expected output is?

I have an inkling this is related to #310 and friends.

@akx akx self-assigned this Jun 9, 2016
@gsakkis
Copy link
Author

gsakkis commented Jun 9, 2016

I don't have a minimal test but I uploaded the original here, along with the output for 2.2.0 and 2.3.4. As you can see some (but not all) strings are missing from the latter.

@akx akx removed their assignment Feb 20, 2023
@gsakkis gsakkis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/messages bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akx @gsakkis @gitmate-bot