Skip to content

Commit 2143d85

Browse files
committed
Update OpFromGraph TODO
1 parent 394b355 commit 2143d85

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

pytensor/compile/builders.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -162,16 +162,9 @@ class OpFromGraph(Op, HasInnerGraph):
162162
Currently does not support ``updates`` or ``givens`` argument.
163163
164164
.. TODO:
165-
- examples for a multi-layer mlp. where?
166-
- __hash__, __eq__ otherwise won't merge, try
167-
is_same_graph_with_merge(op1.local_outputs, op2,
168-
local_outputs)
169-
- c_code() to remove the double overhead?
170-
- grad() make it support DisconnectedType and the new interface
171-
- add support for NullType and DisconnectedType when R_op supports them
172-
- check how it works with updates.
165+
- Allow / test merging of OpFromGraph nodes
166+
- Add support for NullType and DisconnectedType when R_op supports them
173167
- Add support to pickle this Op.
174-
- Add support/test with random generator
175168
- Add optimization to removing unused inputs/outputs
176169
- Add optimization to work inplace on inputs when not inline
177170

0 commit comments

Comments
 (0)