Skip to content

Order of rewrites in logprob submodule is not respected #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Nov 29, 2022 · 0 comments · Fixed by #6370
Closed

Order of rewrites in logprob submodule is not respected #6353

ricardoV94 opened this issue Nov 29, 2022 · 0 comments · Fixed by #6370

Comments

@ricardoV94
Copy link
Member

Description

I could be wrong, but when working on #6072, it seemed that the order of the rewrites in the database is only respected when using the kwarg position. Otherwise it seems to be ignored, and only the order of definition matters.

So:

logprob_rewrites_db.register("measurable_ir_rewrites", measurable_ir_rewrites_db, -10, "basic")

Should be:

logprob_rewrites_db.register( 
     "measurable_ir_rewrites", measurable_ir_rewrites_db, "basic", position=-10, 
 )

We should probably also leave an offset between pre-canonicalize and measurable_ir_rewrites (both are supposed to be at -10) in case anyone wants to introduce rewrites between those two phases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant