Code review

Author: cdce8p

astroid/rebuilder.py

@@ -96,7 +96,7 @@ def __init__(
         manager: AstroidManager,
         parser_module: Optional[ParserModule] = None,
         data: Optional[str] = None,
-    ):
+    ) -> None:
         self._manager = manager
         self._data = data.split("\n") if data else None
         self._global_names: List[Dict[str, List[nodes.Global]]] = []
@@ -195,8 +195,6 @@ def _get_position_info(
         else:
             return None
 
-        start_token = cast(TokenInfo, start_token)  # type: ignore[redundant-cast]  # necessary for pyright
-
         # pylint: disable=undefined-loop-variable
         return Range(
             lineno=node.lineno - 1 + start_token.start[0],

tests/unittest_nodes_position.py

@@ -31,9 +31,13 @@ class D:  #@
         class E:  #@
             def f():
                 ...
+
+        @decorator
+        class F:  #@
+            ...
         """
         ).strip()
-        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore
+        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore[assignment]
 
         a = ast_nodes[0]
         assert isinstance(a, nodes.ClassDef)
@@ -55,6 +59,10 @@ def f():
         assert isinstance(e, nodes.ClassDef)
         assert e.position == (13, 0, 13, 7)
 
+        f = ast_nodes[5]
+        assert isinstance(f, nodes.ClassDef)
+        assert f.position == (18, 0, 18, 7)
+
     @staticmethod
     def test_position_function() -> None:
         """Position should only include keyword and name.
@@ -81,7 +89,7 @@ def e():  #@
             ...
         """
         ).strip()
-        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore
+        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore[assignment]
 
         a = ast_nodes[0]
         assert isinstance(a, nodes.FunctionDef)
@@ -129,7 +137,7 @@ async def e():  #@
             ...
         """
         ).strip()
-        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore
+        ast_nodes: List[nodes.NodeNG] = builder.extract_node(code)  # type: ignore[assignment]
 
         a = ast_nodes[0]
         assert isinstance(a, nodes.FunctionDef)