RDT ad are still displayed with a light background in the dark theme #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

12rambau opened this issue Apr 14, 2022 · 0 comments · Fixed by #629

Collaborator

12rambau commented Apr 14, 2022

I though that was managed by #540 but it seems I forgot things.

Using a dark theme the css of the RDT ad is not changing making them extremely unpleasant to watch:

I'll make a PR to correct that so you can assign this issue to me if you want.

12rambau mentioned this issue

ENH: Dark theme support for ethical ads #629

Merged

choldgraf closed this as completed in #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment