Skip to content

dependencies (html5lib) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaveBackus opened this issue Feb 9, 2016 · 2 comments
Closed

dependencies (html5lib) #171

DaveBackus opened this issue Feb 9, 2016 · 2 comments

Comments

@DaveBackus
Copy link

I suspect this is a naive suggestion, but here's the issue. I'm teaching a course to newbies (data + python) that uses the datareader a lot. We started with Anaconda, which includes pandas, then installed datareader with conda.

It didn't work because we didn't have html5lib installed. Which was easy to fix once we figured it out. But would it make sense to add a check? The code already gives a message referring to html5lib, but it's buried in the traceback. There are probably similar dependencies elsewhere that might get similar treatment.

The context here is that this is a terrific tool and I can see it used by lots of people, including many who are not experienced coders.

Specifics. This refers to the Yahoo options module.

import pandas_datareader.yahoo.options as yho

ticker = 'amzn'
otk = yho.Options(ticker)

cols = [0, 1, 2, 7]
ops = otk.get_all_data()[cols]
@femtotrader
Copy link
Contributor

lxml is an optional dependency for Pandas DataReader but is "required" for Yahoo Options
see https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/yahoo/options.py#L665

Maybe we should

We have to weight the pros and cons of each solution

@bashtage
Copy link
Contributor

This is now a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants