-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New default solar position algorithm #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like the idea. A picture of the poster (with permission) would definitely be nice. |
Solpos is a great algorithm as fast as usno but as accurate as spa and it already has a c implementation. Try |
@mikofski that is awesome, would it be feasible to add the algorithm to pvlib to make it easier for newcomers to use? I wouldn't mind doing the work. |
I would appreciate a Python version of SOLPOS. Or pvlib can also import optional dependent, for example perhaps consider sg2 Past concerns were
SPECTRL2 addition by Kevin resolved these concerns by reimplementing natively. Related / past:
Purpose of listing these just for reference |
A paper is in the works with more detail on this topic. Note that we already have a faster alternative to SPA (
#2152 and #2167 are candidates, but those PRs are on hold for now while we work towards clear recommendations for choice of algorithm.
I do not think this is true, unless "accurate as spa" means "produces practically equivalent solar energy simulations", which is also the case for half a dozen other algorithms :) |
Is your feature request related to a problem? Please describe.
[Solar Position Documentation](https://pvlib-python.readthedocs.io/en/stable/reference/solarposition.html
https://pvlib-python.readthedocs.io/en/stable/reference/generated/) recommends using the default solar position algorithm. Should we update to a faster algorithm given @AdamRJensen's poster at this year's PVPMC which shows that most algorithms have minimal impact on energy regardless of run-time?
With permission I can edit this comment and add a photo of the poster.
Describe the solution you'd like
A fast implementation of the SG2, USNO or NOAA solar position algorithms set as the default model for the
get_solarposition
wrapper.Describe alternatives you've considered
We could leave the default as
nrel_numpy
Additional context
The text was updated successfully, but these errors were encountered: