Skip to content

Is there interest in implementing a .pan or .ond reader into iotools? #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckrening opened this issue May 24, 2023 · 4 comments · Fixed by #1749
Closed

Is there interest in implementing a .pan or .ond reader into iotools? #1747

ckrening opened this issue May 24, 2023 · 4 comments · Fixed by #1749

Comments

@ckrening
Copy link
Contributor

I find that .pan or .ond files are the most widely/easily available files containing parameters to use with the existing module and inverter models in PVlib. I have created read and parse functions to streamline getting those parameters into my code.

Would enough people find this feature useful that I should create a pull request?

@cwhanse
Copy link
Member

cwhanse commented May 24, 2023

@ckrening there is significant interest in having this capability. Pull requests welcome :)

@kandersolar
Copy link
Member

Yes! This has been discussed several times over the years, but nobody has taken the initiative to do it. Here are some related discussions, for reference:

@mikofski
Copy link
Member

Any chance you can reuse our port @frivollier https://github.com/frivollier/pvsyst_tools

@ckrening
Copy link
Contributor Author

Thank you all for the suggestions! I went ahead and created a pull request #1749 using the code I had already created. I took a different approach than the suggested #1002 and #1094. There are trade-offs for either method but, please review and we can discuss what is best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants