Skip to content

ModelChain.pvwatts_losses creates self.losses instead of ModelChainResult.losses #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wholmgren opened this issue Mar 5, 2021 · 0 comments · Fixed by #1231
Closed

ModelChain.pvwatts_losses creates self.losses instead of ModelChainResult.losses #1184

wholmgren opened this issue Mar 5, 2021 · 0 comments · Fixed by #1231
Labels
api bug
Milestone
0.9.0

Comments

@wholmgren
Copy link
Member

@ncroft-b4 reports...

It looks like pvwatts_losses still creates a self.losses attribute.

Thanks for catching that. pvwatts_losses and no_extra_losses should assign values to ModelChainResults, and ModelChain._deprecated_attrs should include losses. We can address that in another issue/pr.

Originally posted by @wholmgren in #1168 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

mc.losses to mc.results.losses wholmgren/pvlib-python
1 participant
@wholmgren