-
Notifications
You must be signed in to change notification settings - Fork 1.1k
make Array play nicely with fixed tilt systems and trackers #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like the idea of depreciating the I think we should keep in mind though that when you have a tracking system you are probably very likely going to have a uniform system and a single I also like the simplicity of Just throwing this out there, what if |
Yes.
True. The main application that I can see for mixing a other_params = {} # module_parameters, etc
PVSystem([
Array(surface_tilt=45, surface_azimuth=90, **other_params),
SingleAxisTrackerArray(**other_params)
])
We discussed deprecating that functionality but haven't committed to it.
Interesting idea. I could see this working at the |
#1076 is adding an
Array
class that largely describes a fixed-tilt array. However, the composition logic ofPVSystem: def __init__(arrays,...)
combined with the inheritance logic ofSingleAxisTracker(PVSystem)
makes for an odd combination ofArray
objects withinSingleAxisTrackers
. See, for example, #1076 (comment).In #1076 (comment) I proposed roughly:
Split the
Array
intoBaseArray
,FixedTiltArray(BaseArray)
,SingleAxisTrackingArray(BaseArray)
? Basic idea:I believe the only major challenge is that the
get_aoi
andget_irradiance
methods would either need to differ in signature (as they do now, and thus present a challenge to aPVSystem
wrapper) or in implementation (tracker methods would include a call tosingleaxis
, and thus would be less efficient in some workflows). @wfvining suggests that the consistent signature is more important and I'm inclined to agree.We'd also deprecate the old
SingleAxisTracking
class.We should resolve this issue before releasing the new Array code into the wild in 0.9.
The text was updated successfully, but these errors were encountered: