Skip to content

Commit c699575

Browse files
alorenzo175wholmgren
authored andcommitted
fix reading MIDC files with mismatching header/data columns (#822)
* fix reading MIDC files with mismatching header/data columns * Update pvlib/iotools/midc.py Co-Authored-By: Will Holmgren <[email protected]> * add timeout argument
1 parent ee6d951 commit c699575

File tree

4 files changed

+1498
-8
lines changed

4 files changed

+1498
-8
lines changed

docs/sphinx/source/whatsnew/v0.7.0.rst

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ API Changes
8484

8585
* Changes related to spectral modifier (:issue:`782`):
8686
* Changes to functions
87-
- Added the argument `pw_min` and `pw_max`, default values 0.1 and 8 resp.,
87+
- Added the argument `pw_min` and `pw_max`, default values 0.1 and 8 resp.,
8888
to `atmosphere.first_solar_spectral_correction`. This function now returns NaN
8989
if pw value higher than `pw_max`.
9090

@@ -101,6 +101,9 @@ API Changes
101101
argument for capability during the deprecation period.
102102
* Parameter `pvsystem.DC_MODEL_PARAMS` is renamed to `pvsystem._DC_MODEL_PARAMS`.
103103
Users should not rely on this dictionary's existence or structure.
104+
* :py:func:`pvlib.iotools.midc.read_midc` now passes additional keyword
105+
arguments to `pandas.read_csv`
106+
* Add `timeout` argument to :py:func:`pvlib.iotools.midc.read_midc_raw_data_from_nrel`
104107

105108
Enhancements
106109
~~~~~~~~~~~~
@@ -133,6 +136,8 @@ Bug fixes
133136
longitude or latitude degree to an index number in a Linke turbidity lookup
134137
table. Also rename the function to `clearsky._degrees_to_index`.
135138
(:issue:`754`)
139+
* Fix reading raw MIDC CSV files from NREL where the number of header
140+
columns does not match the number of data columns.
136141

137142
Testing
138143
~~~~~~~
@@ -152,7 +157,7 @@ Documentation
152157
* Edited docstring for `pvsystem.sapm` to remove DataFrame option for input
153158
`module`. The DataFrame option was never tested and would cause an error if
154159
used. (:issue:`785`)
155-
* Note warning about _TMY3.epw files retrieved from energyplus.net in docstring
160+
* Note warning about _TMY3.epw files retrieved from energyplus.net in docstring
156161
of `epw.read_epw`
157162

158163
Removal of prior version deprecations
@@ -180,3 +185,4 @@ Contributors
180185
* Miguel Sánchez de León Peque (:ghuser:`Peque`)
181186
* Tanguy Lunel (:ghuser:`tylunel`)
182187
* Veronica Guo (:ghuser:`veronicaguo`)
188+
* Tony Lorenzo (:ghuser:`alorenzo175`)

0 commit comments

Comments
 (0)