remove needs_pandas decorator (#885)

* remove definition and applications of pandas_0_22 decorator

* remove needs_pandas_0_17

* Fix backwards path sep (#876)

Fixes #875

* readd needs_pandas_0_22 for test_irradiance.py in travis py35-min

* forecast compat with pandas 1.0, fix bug in Location tz handling (#879)

* fix location tz bug with datetime.timezone.utc

* update whatsnew

* issue in whatsnew

* fix whatsnew class typo

* remove definition and applications of pandas_0_22 decorator

* remove needs_pandas_0_17

* readd needs_pandas_0_22 for test_irradiance.py in travis py35-min

Co-authored-by: Mark Mikofski <[email protected]>
Co-authored-by: Will Holmgren <[email protected]>

Author: 3 people

pvlib/tests/conftest.py

@@ -70,14 +70,6 @@ def inner():
 requires_ephem = pytest.mark.skipif(not has_ephem, reason='requires ephem')
 
 
-def pandas_0_17():
-    return parse_version(pd.__version__) >= parse_version('0.17.0')
-
-
-needs_pandas_0_17 = pytest.mark.skipif(
-    not pandas_0_17(), reason='requires pandas 0.17 or greater')
-
-
 def numpy_1_10():
     return parse_version(np.__version__) >= parse_version('1.10.0')
 

pvlib/tests/iotools/test_psm3.py

@@ -4,7 +4,7 @@
 
 import os
 from pvlib.iotools import psm3
-from conftest import needs_pandas_0_22, DATA_DIR
+from conftest import DATA_DIR
 import numpy as np
 import pandas as pd
 import pytest
@@ -70,7 +70,6 @@ def assert_psm3_equal(header, data, expected):
     assert (data.index.tzinfo.zone == 'Etc/GMT%+d' % -header['Time Zone'])
 
 
-@needs_pandas_0_22
 @pytest.mark.flaky(reruns=5, reruns_delay=2)
 def test_get_psm3_tmy(nrel_api_key):
     """test get_psm3 with a TMY"""
@@ -80,7 +79,6 @@ def test_get_psm3_tmy(nrel_api_key):
     assert_psm3_equal(header, data, expected)
 
 
-@needs_pandas_0_22
 @pytest.mark.flaky(reruns=5, reruns_delay=2)
 def test_get_psm3_singleyear(nrel_api_key):
     """test get_psm3 with a single year"""
@@ -90,7 +88,6 @@ def test_get_psm3_singleyear(nrel_api_key):
     assert_psm3_equal(header, data, expected)
 
 
-@needs_pandas_0_22
 @pytest.mark.flaky(reruns=5, reruns_delay=2)
 def test_get_psm3_check_leap_day(nrel_api_key):
     _, data_2012 = psm3.get_psm3(LATITUDE, LONGITUDE, nrel_api_key,
@@ -105,7 +102,6 @@ def test_get_psm3_check_leap_day(nrel_api_key):
                           (LATITUDE, LONGITUDE, nrel_api_key, 'bad', 60),
                           (LATITUDE, LONGITUDE, nrel_api_key, '2017', 15),
                           ])
-@needs_pandas_0_22
 @pytest.mark.flaky(reruns=5, reruns_delay=2)
 def test_get_psm3_tmy_errors(
     latitude, longitude, api_key, names, interval
@@ -134,15 +130,13 @@ def io_input(request):
     return obj
 
 
-@needs_pandas_0_22
 def test_parse_psm3(io_input):
     """test parse_psm3"""
     header, data = psm3.parse_psm3(io_input)
     expected = pd.read_csv(YEAR_TEST_DATA)
     assert_psm3_equal(header, data, expected)
 
 
-@needs_pandas_0_22
 def test_read_psm3():
     """test read_psm3"""
     header, data = psm3.read_psm3(MANUAL_TEST_DATA)

pvlib/tests/test_solarposition.py

@@ -12,8 +12,7 @@
 from pvlib.location import Location
 from pvlib import solarposition, spa
 
-from conftest import (requires_ephem, needs_pandas_0_17,
-                      requires_spa_c, requires_numba)
+from conftest import requires_ephem, requires_spa_c, requires_numba
 
 
 # setup times and locations to be tested.
@@ -164,7 +163,6 @@ def test_spa_python_numpy_physical_dst(expected_solpos, golden):
     assert_frame_equal(expected_solpos, ephem_data[expected_solpos.columns])
 
 
-@needs_pandas_0_17
 def test_sun_rise_set_transit_spa(expected_rise_set_spa, golden):
     # solution from NREL SAP web calculator
     south = Location(-35.0, 0.0, tz='UTC')